git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Bucur <stefan.bucur@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: git@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Wrong file diff for merge conflict
Date: Mon, 6 Jul 2009 17:44:56 +0300	[thread overview]
Message-ID: <8cdebd3f0907060744l75a11160v8b01e6923cc5c70e@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.2.01.0907051726020.3210@localhost.localdomain>

On Mon, Jul 6, 2009 at 3:33 AM, Linus
Torvalds<torvalds@linux-foundation.org> wrote:
[...]
>
> The fact is, a traditional rcs three-way merge (which is pretty much what
> you get with git, ignoring the fact that we have other tools in addition
> to it, and ignoring things like criss-cross merges etc) just doesn't work
> the way you seem to think it should work. You simply don't get the
> original of one side by picking one side of the conflict markers. It will
> have merged the stuff that it thought merged cleanly, and not have any
> conflict markers at all for those parts.
>
> Of course, "what it thought merged cleanly" may not be what you want it to
> be. Sometimes you get a clean merge for things that you'd have wanted to
> conflict. And sometimes you get conflicts for stuff that you'd think is
> just silly and shouldn't have.
>
> There are no perfect file merge algorithms that I know of. Lots of people
> hate the diff3/merge behavior - it's by no means perfect. But so far, I've
> never seen anybody successfully advocate anything better either.
>
>                Linus
>

Indeed it seems I had a wrong image of how a conflict file should
look. In the light of what you've told me now, everything makes sense
:) Thank you very much for taking your time to explain these things!

Cheers,
Stefan Bucur

      reply	other threads:[~2009-07-06 14:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-04  7:53 Wrong file diff for merge conflict Stefan Bucur
2009-07-05 18:43 ` Linus Torvalds
2009-07-05 19:22   ` Jakub Narebski
2009-07-05 19:23   ` Junio C Hamano
2009-07-05 22:23   ` Stefan Bucur
2009-07-06  0:33     ` Linus Torvalds
2009-07-06 14:44       ` Stefan Bucur [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8cdebd3f0907060744l75a11160v8b01e6923cc5c70e@mail.gmail.com \
    --to=stefan.bucur@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=hpa@zytor.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).