From: Dragan Simic <dsimic@manjaro.org>
To: Ralph Seichter <github@seichter.de>
Cc: Junio C Hamano <gitster@pobox.com>,
rsbecker@nexbridge.com, Chris Torek <chris.torek@gmail.com>,
git@vger.kernel.org,
Ralph Seichter via GitGitGadget <gitgitgadget@gmail.com>
Subject: Re: [PATCH 3/1] config: allow tweaking whitespace between value and comment
Date: Wed, 27 Mar 2024 02:23:52 +0100 [thread overview]
Message-ID: <8d05e767aa5ba30e91522835fb2941b8@manjaro.org> (raw)
In-Reply-To: <871q7wv7s1.fsf@ra.horus-it.com>
Hello Ralph,
On 2024-03-27 01:27, Ralph Seichter wrote:
> * Junio C. Hamano:
>
>> The easiest would have been for you to say "Yup, the two additional
>> patches queued on top of mine seem to make it better. [...]
>
> Would it? Well, you wrote the following two weeks ago, among other
> things:
>
>>> I thought we already discussed this and unconditional "#comment" has
>>> already been declared a non starter.
>
> This unilateral decision of yours, and the following prolonged debate
> about spaces/tabs (which I clearly stated I consider a waste of time)
> left me with the impression that what I think doesn't matter much
> anyway. Also, it seems to me that this whole subject has already been
> blown far out of proportion. If this exercise leads to the feature I
> was
> proposing, you guys can do whatever, and I won't slow things down by
> expressing my opinions, or by continuing to formulate my own commit
> messages. So much time has already been spent.
Well, is getting patches accepted to git hard and often challenging?
Absolutely. Do additional patches and discussions sprout all over the
place? They obviously do. But, does a high-profile open-source project
deserve such an approach? Without doubt.
In fact, pretty much every good software project should employ such an
approach, but that unfortunately isn't always the case.
That's how I see it.
next prev parent reply other threads:[~2024-03-27 1:23 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 6:00 [PATCH] Allow git-config to append a comment Ralph Seichter via GitGitGadget
2024-03-06 16:01 ` Junio C Hamano
2024-03-06 17:24 ` Ralph Seichter
2024-03-07 12:12 ` Junio C Hamano
2024-03-07 12:44 ` Ralph Seichter
2024-03-07 13:27 ` Junio C Hamano
2024-03-07 13:53 ` rsbecker
2024-03-07 15:26 ` Ralph Seichter
2024-03-07 15:40 ` rsbecker
2024-03-07 15:57 ` Ralph Seichter
2024-03-07 15:15 ` [PATCH v2] config: add --comment option to add " Ralph Seichter via GitGitGadget
2024-03-11 12:55 ` Junio C Hamano
2024-03-11 16:17 ` Dragan Simic
2024-03-11 16:48 ` rsbecker
2024-03-11 17:00 ` Dragan Simic
2024-03-11 17:52 ` Dragan Simic
2024-03-11 17:29 ` Junio C Hamano
2024-03-11 17:34 ` Dragan Simic
2024-03-11 19:54 ` Junio C Hamano
2024-03-12 2:25 ` Dragan Simic
2024-03-11 18:23 ` Ralph Seichter
2024-03-11 18:50 ` Dragan Simic
2024-03-11 18:57 ` Ralph Seichter
2024-03-11 19:04 ` Dragan Simic
2024-03-11 21:31 ` Junio C Hamano
2024-03-12 2:38 ` Dragan Simic
2024-03-11 19:17 ` rsbecker
2024-03-12 2:27 ` Dragan Simic
2024-03-11 18:16 ` Ralph Seichter
2024-03-11 18:55 ` Dragan Simic
2024-03-11 19:04 ` Ralph Seichter
2024-03-12 6:19 ` Ralph Seichter
2024-03-12 6:37 ` Chris Torek
2024-03-12 7:28 ` Ralph Seichter
2024-03-12 7:44 ` Junio C Hamano
2024-03-12 21:47 ` [PATCH v3] " Ralph Seichter via GitGitGadget
2024-03-15 22:15 ` Junio C Hamano
2024-03-15 22:26 ` [PATCH 3/1] config: allow tweaking whitespace between value and comment Junio C Hamano
2024-03-26 22:06 ` Junio C Hamano
2024-03-26 22:48 ` Ralph Seichter
2024-03-26 23:27 ` Junio C Hamano
2024-03-27 0:27 ` Ralph Seichter
2024-03-27 1:23 ` Dragan Simic [this message]
2024-03-27 17:27 ` Junio C Hamano
2024-03-15 23:10 ` [PATCH v3] config: add --comment option to add a comment Eric Sunshine
2024-03-15 23:41 ` Junio C Hamano
2024-03-15 23:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d05e767aa5ba30e91522835fb2941b8@manjaro.org \
--to=dsimic@manjaro.org \
--cc=chris.torek@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=github@seichter.de \
--cc=gitster@pobox.com \
--cc=rsbecker@nexbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).