From: "René Scharfe" <l.s.r@web.de>
To: Denton Liu <liu.denton@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] test: use test_must_be_empty F instead of test_cmp empty F
Date: Wed, 27 Nov 2019 08:51:09 +0100 [thread overview]
Message-ID: <8dc0b50d-4e41-bc79-33a1-7e2a1ef7aa0b@web.de> (raw)
In-Reply-To: <20191126200239.GA36748@generichostname>
Am 26.11.19 um 21:02 schrieb Denton Liu:
>> diff --git a/t/t9010-svn-fe.sh b/t/t9010-svn-fe.sh
>> index 0b20b07e68..3a3d8d3bd5 100755
>> --- a/t/t9010-svn-fe.sh
>> +++ b/t/t9010-svn-fe.sh
>> @@ -53,9 +53,7 @@ text_no_props () {
>> printf "%s\n" "$text"
>> }
>>
>> ->empty
>> -
>> -test_expect_success 'empty dump' '
>> +test_expect_success PIPE 'empty dump' '
>
> How come we need the PIPE prereq here? At the top of this file, we have
>
> if test_have_prereq !PIPE
> then
> skip_all="svn dumpfile importer testing requires the PIPE prerequisite"
> test_done
> fi
>
> which should guarantee PIPE at this point already.
Right, we haven't needed it since 7236a34c98 (t9010-*.sh: skip all tests
if the PIPE prereq is missing, 2017-09-17). Thanks for catching this!
My patch had been gathering dust here already before that time, and
sometime along the way I did a sloppy rebase. Didn't see it before
sending because I was focusing on "can we remove the empty file?". O_o
René
next prev parent reply other threads:[~2019-11-27 7:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 19:46 [PATCH] test: use test_must_be_empty F instead of test_cmp empty F René Scharfe
2019-11-26 20:02 ` Denton Liu
2019-11-27 7:51 ` René Scharfe [this message]
2019-11-27 7:51 ` [PATCH v2] " René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8dc0b50d-4e41-bc79-33a1-7e2a1ef7aa0b@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).