From: "Duncan Mak" <duncan@a-chinaman.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fix vc git
Date: Thu, 21 Dec 2006 23:11:32 -0500 [thread overview]
Message-ID: <8e745ecf0612212011q26f81d91uce143b4212fc5e8b@mail.gmail.com> (raw)
In-Reply-To: <7vhcvo92fx.fsf@assigned-by-dhcp.cox.net>
I don't think vc-git-registered-file will ever be called with a
filename without a directory, as it is used as a hook on
vc-next-action, which works on a real file.
Either way, it's a modified patch:
Fix vc-git.el to not cd into a non-existent directory.
---
contrib/emacs/vc-git.el | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
base c902c9a608c1b727160d6fbb04fa363d9418cd00
last 96e9944b714094ab81f8091711a92506886b8004
diff --git a/contrib/emacs/vc-git.el b/contrib/emacs/vc-git.el
index 8b6361922fd6e6a2fcd9acb20fd54f5b645b36f0..668bd4a98653046aadf91e7a91af6cd76ba044d4
100644
--- a/contrib/emacs/vc-git.el
+++ b/contrib/emacs/vc-git.el
@@ -58,7 +58,7 @@
(with-temp-buffer
(let* ((dir (file-name-directory file))
(name (file-relative-name file dir)))
- (when dir (cd dir))
+ (when (and dir (file-exists-p dir)) (cd dir))
(and (ignore-errors (eq 0 (call-process "git" nil '(t nil) nil
"ls-files" "-c" "-z" "--" name)))
(let ((str (buffer-string)))
(and (> (length str) (length name))
--
1.4.4.1
next prev parent reply other threads:[~2006-12-22 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-21 11:25 [PATCH] fix vc git Duncan Mak
2006-12-21 11:32 ` Jakub Narebski
2006-12-21 11:59 ` Duncan Mak
2006-12-22 0:52 ` Junio C Hamano
2006-12-22 4:11 ` Duncan Mak [this message]
2006-12-22 4:54 ` Junio C Hamano
2006-12-22 12:39 ` Alexandre Julliard
2006-12-22 12:51 ` Duncan Mak
2006-12-22 13:56 ` Alexandre Julliard
2006-12-22 15:17 ` Duncan Mak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e745ecf0612212011q26f81d91uce143b4212fc5e8b@mail.gmail.com \
--to=duncan@a-chinaman.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).