From: "Jakub Narebski" <jnareb@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/7] gitweb: Expand href() function to use key as param name for no mapping
Date: Thu, 17 Aug 2006 12:08:06 +0200 [thread overview]
Message-ID: <8fe92b430608170308n42942798xf50f814052bee1c4@mail.gmail.com> (raw)
In-Reply-To: <7v8xlnsmyl.fsf@assigned-by-dhcp.cox.net>
On 8/17/06, Junio C Hamano <junkio@cox.net> wrote:
> Jakub Narebski <jnareb@gmail.com> writes:
>
> > Expand href() function to use key name of params hash as a query param
> > name, if there is no mapping for given key name.
> >
> > It is now safer to use href(); no errors, but links might not work
> > correctly if caller didn't provide correct arguments.
> >
> > Future proofing.
>
> I think that is not a "future proofing" but is "sweeping mess
> under the rug" ;-).
At least leave 'if (exists $mapping{$_})' even if you remove the 'else' part.
[...]
> Obviously unrelated and probably unplanned revert of [2/7] in
> the series, so will not apply.
Ooops, sorry, I haven't noticed this... Very unplanned.
--
Jakub Narebski
next prev parent reply other threads:[~2006-08-17 10:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 9:21 [PATCH 0/7] A few gitweb cleanups and improvements Jakub Narebski
2006-08-17 9:21 ` [PATCH 1/7] gitweb: Add support for per project git URLs Jakub Narebski
2006-08-17 18:58 ` David Rientjes
2006-08-17 9:21 ` [PATCH 2/7] gitweb: Refactor printing commit message Jakub Narebski
2006-08-17 9:21 ` [PATCH 3/7] gitweb: Fix typo in separation of git_difftree_body Jakub Narebski
2006-08-17 9:21 ` [PATCH 4/7] gitweb: Expand href() function to use key as param name for no mapping Jakub Narebski
2006-08-17 9:58 ` Junio C Hamano
2006-08-17 10:08 ` Jakub Narebski [this message]
2006-08-17 9:21 ` [PATCH 5/7] gitweb: Added parse_difftree_raw_line function for later use Jakub Narebski
2006-08-17 9:55 ` Junio C Hamano
2006-08-17 9:21 ` [PATCH 6/7] gitweb: Sort query string parameters in href() function Jakub Narebski
2006-08-17 9:21 ` [PATCH 7/7] gitweb: Uniquify version info output, add meta generator in page header Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8fe92b430608170308n42942798xf50f814052bee1c4@mail.gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).