git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tarmigan <tarmigan+git@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: What's cooking in git.git (Nov 2009, #02; Sun, 08)
Date: Tue, 10 Nov 2009 09:10:36 -0800	[thread overview]
Message-ID: <905315640911100910r5116779eh24796fa5788f4aef@mail.gmail.com> (raw)
In-Reply-To: <7vzl6wz36r.fsf@alter.siamese.dyndns.org>

Sorry to bug you so soon again, Shawn.  Thanks for your help.

On Sun, Nov 8, 2009 at 9:18 PM, Junio C Hamano <gitster@pobox.com> wrote:
> * sp/smart-http (2009-11-04) 30 commits
>  + http-backend: Test configuration options
>  + http-backend: Use http.getanyfile to disable dumb HTTP serving
>  + test smart http fetch and push

OK now I'm testing on OSX with Apache/2.2.11, and curl 7.19.4.

Testing on 7f640b778f8cf87159890157a815f1d728573477, I am getting
failures starting in the third test of t5560-http-backend.sh, "static
file is ok".  I also get failures on the test after ("static file if
http.getanyfile true is ok") and in the log compare (obviously), but I
think those will go away when test 3 is fixed, so I have not looked
into them.

Specifically, the GET of info/refs makes something on my machine
unhappy.  Curl returns 18 (CURLE_PARTIAL_FILE), the test takes a long
time to fail, and the "out" file looks OK (compared to a linux machine
where the test passes) expect for "Content-Length: 37847251812411".
The exact line does not work is
curl --include http://127.0.0.1:5560/smart/repo.git/info/refs

Digging into it a bit more with gdb, the call to hdr_int() in
http-backend.c looks OK, but then something goes wrong in
format_write().  Hmmm it looks like my setup does not like PRIuMAX
with size_t, which puts some garbage in the upper bytes of
Content-Length.  Changing the PRIuMAX to a %zu allows all the tests to
pass, but that may not be the preferred solution.

Thanks,
Tarmigan

  parent reply	other threads:[~2009-11-10 17:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-09  5:18 What's cooking in git.git (Nov 2009, #02; Sun, 08) Junio C Hamano
2009-11-09  8:08 ` Tarmigan
2009-11-09 15:29   ` Shawn O. Pearce
2009-11-10 17:10 ` Tarmigan [this message]
2009-11-12  4:42   ` [PATCH] http-backend: Fix bad treatment of uintmax_t in Content-Length Shawn O. Pearce
2009-11-14 21:49     ` Tarmigan
2009-11-15  9:08       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=905315640911100910r5116779eh24796fa5788f4aef@mail.gmail.com \
    --to=tarmigan+git@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).