From: Tarmigan <tarmigan+git@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, rctay89@gmail.com, drizzd@aon.at,
warthog9@kernel.org
Subject: Re: [PATCH 2/2] Smart-http: check if repository is OK to export before serving it
Date: Sun, 27 Dec 2009 23:07:26 -0500 [thread overview]
Message-ID: <905315640912272007i8b4904dv2b93879789b453fb@mail.gmail.com> (raw)
In-Reply-To: <20091227211033.GB609@spearce.org>
On Sun, Dec 27, 2009 at 4:10 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Tarmigan Casebolt <tarmigan+git@gmail.com> wrote:
>> Similar to how git-daemon checks whether a repository is OK to be
>> exported, smart-http should also check. This check can be satisfied
>> in two different ways: the environmental variable GIT_HTTP_EXPORT_ALL
>> may be set to export all repositories, or the individual repository
>> may have the file git-daemon-export-ok.
>>
>> Signed-off-by: Tarmigan Casebolt <tarmigan+git@gmail.com>
>
> Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> I really think this and 1/2 should be squashed together, in which
> case you can apply my ACK to the entire thing.
Great, thanks for the ACK.
Squashing sounds good to me, I just split it so someone could verify
that the tests fail first if they want.
I've been thinking that the not_found() to a forbidden() instead.
Thoughts? I'll send out a unified patch with that change in a reply.
Thanks,
Tarmigan
next prev parent reply other threads:[~2009-12-28 4:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-26 16:21 Does smart-http need git-daemon-export-ok? Tarmigan
2009-12-26 17:33 ` Junio C Hamano
2009-12-26 23:29 ` [PATCH 1/2] Smart-http: Add tests and documentation for export-ok Tarmigan Casebolt
2009-12-26 23:29 ` [PATCH 2/2] Smart-http: check if repository is OK to export before serving it Tarmigan Casebolt
2009-12-27 21:10 ` Shawn O. Pearce
2009-12-28 4:07 ` Tarmigan [this message]
2009-12-28 4:22 ` [PATCH] " Tarmigan Casebolt
2009-12-28 15:59 ` [PATCH 2/2] " Shawn O. Pearce
2009-12-28 16:57 ` Tarmigan
2009-12-28 17:08 ` Shawn O. Pearce
2009-12-28 21:49 ` [PATCH] " Tarmigan Casebolt
2009-12-29 9:19 ` Junio C Hamano
2009-12-29 15:00 ` Shawn O. Pearce
2009-12-27 21:06 ` Does smart-http need git-daemon-export-ok? Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=905315640912272007i8b4904dv2b93879789b453fb@mail.gmail.com \
--to=tarmigan+git@gmail.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rctay89@gmail.com \
--cc=spearce@spearce.org \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).