From: Derrick Stolee <stolee@gmail.com>
To: "Jeff King" <peff@peff.net>, "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH 3/9] convert "oidcmp() == 0" to oideq()
Date: Mon, 27 Aug 2018 08:33:25 -0400 [thread overview]
Message-ID: <909de6f4-0b30-b9d9-637c-a86497f86d8e@gmail.com> (raw)
In-Reply-To: <62172db4-15b2-eac3-8591-246300db3948@gmail.com>
On 8/27/2018 8:31 AM, Derrick Stolee wrote:
> On 8/25/2018 4:36 AM, Jeff King wrote:
>> On Sat, Aug 25, 2018 at 04:07:15AM -0400, Jeff King wrote:
>>
>>> diff --git a/contrib/coccinelle/object_id.cocci
>>> b/contrib/coccinelle/object_id.cocci
>>> index 5869979be7..548c02336d 100644
>>> --- a/contrib/coccinelle/object_id.cocci
>>> +++ b/contrib/coccinelle/object_id.cocci
>>> @@ -108,3 +108,9 @@ expression E1, E2;
>>> @@
>>> - hashcpy(E1.hash, E2->hash)
>>> + oidcpy(&E1, E2)
>
> Is this change intended? It doesn't seem to match the intention of the
> rest of the patch.
Ignore me. It's just confusing to read the +/- notation from a cocci
script alongside the file diff.
next prev parent reply other threads:[~2018-08-27 12:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-25 8:00 [PATCH 0/9] introducing oideq() Jeff King
2018-08-25 8:03 ` [PATCH 1/9] coccinelle: use <...> for function exclusion Jeff King
2018-08-25 8:05 ` [PATCH 2/9] introduce hasheq() and oideq() Jeff King
2018-08-25 10:58 ` Andrei Rybak
2018-08-25 8:07 ` [PATCH 3/9] convert "oidcmp() == 0" to oideq() Jeff King
2018-08-25 8:36 ` Jeff King
2018-08-27 12:31 ` Derrick Stolee
2018-08-27 12:33 ` Derrick Stolee [this message]
2018-08-25 8:08 ` [PATCH 4/9] convert "hashcmp() == 0" to hasheq() Jeff King
2018-08-25 8:09 ` [PATCH 5/9] convert "oidcmp() != 0" to "!oideq()" Jeff King
2018-08-25 8:10 ` [PATCH 6/9] convert "hashcmp() != 0" to "!hasheq()" Jeff King
2018-08-25 8:14 ` [PATCH 7/9] convert hashmap comparison functions to oideq() Jeff King
2018-08-25 8:15 ` [PATCH 8/9] read-cache: use oideq() in ce_compare functions Jeff King
2018-08-25 8:17 ` [PATCH 9/9] show_dirstat: simplify same-content check Jeff King
2018-08-25 8:20 ` Eric Sunshine
2018-08-25 8:23 ` Jeff King
2018-08-26 20:56 ` [PATCH 0/9] introducing oideq() brian m. carlson
2018-08-27 12:41 ` Derrick Stolee
2018-08-28 21:21 ` Jeff King
2018-08-28 21:22 ` [PATCH v2 1/9] coccinelle: use <...> for function exclusion Jeff King
2018-08-28 21:22 ` [PATCH v2 2/9] introduce hasheq() and oideq() Jeff King
2018-08-28 21:22 ` [PATCH v2 3/9] convert "oidcmp() == 0" to oideq() Jeff King
2018-08-28 21:22 ` [PATCH v2 4/9] convert "hashcmp() == 0" to hasheq() Jeff King
2018-08-28 21:22 ` [PATCH v2 5/9] convert "oidcmp() != 0" to "!oideq()" Jeff King
2018-08-28 21:22 ` [PATCH v2 6/9] convert "hashcmp() != 0" to "!hasheq()" Jeff King
2018-08-28 21:22 ` [PATCH v2 7/9] convert hashmap comparison functions to oideq() Jeff King
2018-08-28 21:22 ` [PATCH v2 8/9] read-cache: use oideq() in ce_compare functions Jeff King
2018-08-28 21:23 ` [PATCH v2 9/9] show_dirstat: simplify same-content check Jeff King
2018-08-28 21:36 ` [PATCH 0/9] introducing oideq() Derrick Stolee
2018-08-29 0:08 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=909de6f4-0b30-b9d9-637c-a86497f86d8e@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).