Git development
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: ds/trace2-tolerate-failed-timestamp (was Re: What's cooking in git.git (Oct 2026, #02))
Date: Tue, 6 Oct 2026 10:38:10 -0400	[thread overview]
Message-ID: <91339226-5026-4618-a642-eb2267038f74@gmail.com> (raw)
In-Reply-To: <xmqqwlrviv8g.fsf@gitster.g>

On 10/5/2026 7:27 PM, Junio C Hamano wrote:

> * ds/trace2-tolerate-failed-timestamp (2026-08-31) 7 commits
>  - trace2: remove use of xcalloc()
>  - trace2: remove use of ALLOC_GROW()
>  - trace2: remove use of xstrfmt()
>  - trace2: remove use of ALLOC_ARRAY()
>  - trace2: remove use of xstrdup()
>  - trace2: tolerate failed timestamp formatting
>  - banned-die: create header for banning of functions
> 
>  Functions like `xstrfmt()` and `xcalloc()` have been banned from use
>  in the trace2 API codebase to prevent calls to `die()` which lead to
>  unwanted process exits and recursion when memory allocation fails.
> 
>  Needs review.
>  source: <pull.2178.v3.git.1788197143.gitgitgadget@gmail.com>

This can be evicted. It's not delivering much value for the
complexity that it adds, and having banned-die.h present in the
repo may suggest stronger protections than it really promises.

Thanks,
-Stolee


      reply	other threads:[~2026-10-06 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 23:27 What's cooking in git.git (Oct 2026, #02) Junio C Hamano
2026-10-06 14:38 ` Derrick Stolee [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=91339226-5026-4618-a642-eb2267038f74@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox