From: "Rafael Ascensão" <rafa.almas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Cc: me@ikke.info, hjemli@gmail.com, mhagger@alum.mit.edu,
pclouds@gmail.com, ilari.liusvaara@elisanet.fi
Subject: Re: [PATCH v1 2/2] log: add option to choose which refs to decorate
Date: Mon, 6 Nov 2017 03:24:02 +0000 [thread overview]
Message-ID: <9168f7b8-3b9d-a933-e542-ae5b741cb824@gmail.com> (raw)
In-Reply-To: <xmqqshdtl057.fsf@gitster.mtv.corp.google.com>
Would checking the output of ref_exists() make sense here?
By that I mean, only add a trailing '/*' if the ref doesn't exist.
Unless I am missing something obvious this would allow us to keep both
shortcuts and exact patterns.
next prev parent reply other threads:[~2017-11-06 3:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 0:41 [PATCH v1 0/2] Add option to git log to choose which refs receive decoration Rafael Ascensão
2017-11-04 0:41 ` [PATCH v1 1/2] refs: extract function to normalize partial refs Rafael Ascensão
2017-11-04 2:27 ` Junio C Hamano
2017-11-04 7:33 ` Rafael Ascensão
2017-11-04 22:45 ` Kevin Daudt
2017-11-05 13:21 ` Michael Haggerty
2017-11-05 13:42 ` Michael Haggerty
2017-11-06 1:23 ` Junio C Hamano
2017-11-06 2:37 ` Rafael Ascensão
2017-11-06 7:00 ` Michael Haggerty
2017-11-04 0:41 ` [PATCH v1 2/2] log: add option to choose which refs to decorate Rafael Ascensão
2017-11-04 3:49 ` Junio C Hamano
2017-11-04 7:34 ` Rafael Ascensão
2017-11-05 2:00 ` Junio C Hamano
2017-11-05 6:17 ` Junio C Hamano
2017-11-06 3:24 ` Rafael Ascensão [this message]
2017-11-06 3:51 ` Junio C Hamano
2017-11-06 7:09 ` Michael Haggerty
2017-11-06 20:10 ` Jacob Keller
2017-11-07 0:18 ` Junio C Hamano
2017-11-10 13:38 ` Rafael Ascensão
2017-11-10 17:42 ` Junio C Hamano
2017-11-21 21:33 ` [PATCH v2] " Rafael Ascensão
2017-11-22 4:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9168f7b8-3b9d-a933-e542-ae5b741cb824@gmail.com \
--to=rafa.almas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
--cc=ilari.liusvaara@elisanet.fi \
--cc=me@ikke.info \
--cc=mhagger@alum.mit.edu \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).