From: Derrick Stolee <stolee@gmail.com>
To: Shubham Kanodia <shubham.kanodia10@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: Prefetch maintenance might lead to thundering herd issues
Date: Sun, 22 Sep 2024 21:26:40 -0400 [thread overview]
Message-ID: <91bf8c63-b2fc-48ca-a6de-37a576ddc1b1@gmail.com> (raw)
In-Reply-To: <CAG=Um+2g-pn3XmC4MVkA+UAGeWpHw5U6fe=zXR=6-ibu3d0qsg@mail.gmail.com>
On 9/22/24 2:40 PM, Shubham Kanodia wrote:
> On Sat, Sep 21, 2024 at 1:20 AM Derrick Stolee <stolee@gmail.com> wrote:
>> This is already handled by using a random minute of the hour, as
>> implemented in 9b43399057 (maintenance: use random minute in cron
>> scheduler, 2023-08-10), for example. There are similar uses for
>> systemd, launchctl, and schtasks schedulers (look for uses of
>> the get_random_minute() method).
> Ah, thanks for pointing that out. It wasn't really clear from the
> multiple examples and cron expressions on the git
> maintenance documentation page (which have examples such as `0 1-23 *
> * *` for hourly). I should've looked
> more deeply into the implementation.
>
> Perhaps adding a line to the existing doc might be of help? What do
> you think about adding a line to the
> section on scheduling —
I do think a doc change would help. Please submit it as a patch for
review!
Thanks,
-Stolee
prev parent reply other threads:[~2024-09-23 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 15:15 Prefetch maintenance might lead to thundering herd issues Shubham Kanodia
2024-09-20 19:20 ` Derrick Stolee
2024-09-22 18:40 ` Shubham Kanodia
2024-09-23 1:26 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91bf8c63-b2fc-48ca-a6de-37a576ddc1b1@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=shubham.kanodia10@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).