From: Dragan Simic <dsimic@manjaro.org>
To: Olliver Schinagl <oliver@schinagl.nl>
Cc: Junio C Hamano <gitster@pobox.com>,
Chris Torek <chris.torek@gmail.com>,
Kristoffer Haugsbakk <code@khaugsbakk.name>,
Karthik Nayak <karthik.188@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 0/2] Support diff.wordDiff config
Date: Mon, 25 Mar 2024 22:53:55 +0100 [thread overview]
Message-ID: <91f0848b917a15873a7b75b380619126@manjaro.org> (raw)
In-Reply-To: <6e035003-0c08-4e44-811c-27d2cebe9fa8@schinagl.nl>
On 2024-03-22 23:08, Olliver Schinagl wrote:
> On 03-03-2024 18:45, Junio C Hamano wrote:
>> Chris Torek <chris.torek@gmail.com> writes:
>>
>>> This tension is relieved somewhat when there *are* separate
>>> plumbing commands, such as `git diff-index` and `git diff-tree`
>>> and so on, or `git rev-list` vs `git log`. Unfortunately there
>>> are some commands, including `git log` itself, that have options
>>> that are missing from the roughly-equivalent plumbing command,
>>> and there are commands (such as `git stash` and `git status`)
>>> that either do not have, or at one time lacked, plumbing command
>>> equivalents or options.
>>
>> Yup. It is my pet peeve that more and more contributors got lazy
>> and tweaked only Porcelain commands, without bothering to improve
>> plumbing commands to match, while adding more features during the
>> last decade. Unfortunately there is no easy remedy after such sins
>> have been committed. Once people start using `git log` in their
>> scripts, it is way too late to tell them to update their scripts to
>> use `git log --porcelain`. The fact that you need to tell them is
>> an admission that you already broke their scripts.
>>
> To avoid this request from dieing quietly, I will ask (complain)
> again. Who's the client for. How important is the human UX?
>
> Even introducing a new cli, 'git-cli-for-humans' it will be abused
> again for sure. So what's a good way forward? Personally, as I
> mentioned before, it's in the docs to not script around non-plumbing
> commands, which gives an opening to the admission. And why is
> admitting things a bad thing, when it improves things for the human?
> Even if it hurts.
>
> One could argue 'git3 will break things! Human and machine control is
> split. Use --porcelain (or plumbing commands) in your scripts or
> expect breakage from time to time. You have been warned!'
>
> We do in the end want progress, do we not? :)
Maybe, but just maybe, a possible solution for introducing such new
configuration options could be introduce a new category of configuration
options, which could be set in the user's git configuration only?
That way, a repository enabling some troublesome configuration option
wouldn't cause the user's scripts to break.
next prev parent reply other threads:[~2024-03-25 21:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 8:54 Allow setting diff.worddiff=color via gitconfig Olliver Schinagl
2024-03-02 9:57 ` [PATCH 0/2] Support diff.wordDiff config Karthik Nayak
2024-03-02 9:57 ` [PATCH 1/2] t4034: extract out `diff_with_opts` Karthik Nayak
2024-03-02 9:57 ` [PATCH 2/2] diff: add 'diff.wordDiff' config option Karthik Nayak
2024-03-02 10:25 ` Eric Sunshine
2024-03-02 18:02 ` Karthik Nayak
2024-03-02 19:57 ` Jean-Noël AVILA
2024-03-02 17:03 ` [PATCH 0/2] Support diff.wordDiff config Junio C Hamano
2024-03-02 18:02 ` Karthik Nayak
2024-03-02 19:57 ` Kristoffer Haugsbakk
2024-03-03 7:23 ` Chris Torek
2024-03-03 17:45 ` Junio C Hamano
2024-03-22 22:08 ` Olliver Schinagl
2024-03-25 21:53 ` Dragan Simic [this message]
2024-03-22 22:05 ` Olliver Schinagl
2024-03-22 21:59 ` Olliver Schinagl
2024-03-22 21:57 ` Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91f0848b917a15873a7b75b380619126@manjaro.org \
--to=dsimic@manjaro.org \
--cc=chris.torek@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=oliver@schinagl.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).