Git development
 help / color / mirror / Atom feed
From: Ben Knoble <ben.knoble@gmail.com>
To: Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Ophir Bleicher <ophirble@gmail.com>
Subject: Re: [PATCH] doc: fix AsciiDoc syntax
Date: Fri, 20 Nov 2026 12:54:24 -0500	[thread overview]
Message-ID: <93127462-BCFD-4086-B19D-4B640F515140@gmail.com> (raw)
In-Reply-To: <pull.2496.git.git.1795194752259.gitgitgadget@gmail.com>


> Le 20 nov. 2026 à 12:31, Ophir Bleicher via GitGitGadget <gitgitgadget@gmail.com> a écrit :
> 
> From: Ophir Bleicher <ophirble@gmail.com>
> 
> The Documentation/MyFirstContribution.adoc file accidentally used
> Markdown syntax for a link:
> 
> [here](https://gitgitgadget.github.io/#...)
> 
> Fixed it to use AsciiDoc:
> 
> https://gitgitgadget.github.io/#...[here]

Good catch.

While we’re at it, « here » is generally discouraged as link text.
It’s not particularly accessible for screen-readers, for example.

> Signed-off-by: Ophir Bleicher <ophirble@gmail.com>
> ---
>    doc: fix AsciiDoc syntax
> 
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v1
> Pull-Request: https://github.com/git/git/pull/2496
> 
> Documentation/MyFirstContribution.adoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc
> index c58253fd54..3b531b24fa 100644
> --- a/Documentation/MyFirstContribution.adoc
> +++ b/Documentation/MyFirstContribution.adoc
> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull
> request" button that may appear with the name of your newly pushed branch.
> 
> The differences between using `gitgitgadget/git` and `git/git` as your base can
> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror)
> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here]

So perhaps we could reword this to something like

    Further [differences between …] are described online.

with the brackets marking the link text?

> Review the PR's title and description, as they're used by GitGitGadget
> respectively as the subject and body of the cover letter for your change. Refer
> 
> base-commit: f7de81456940dd6f3274e461149bba12965de609
> --
> gitgitgadget
> 

  reply	other threads:[~2026-11-20 17:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-20 17:12 [PATCH] doc: fix AsciiDoc syntax Ophir Bleicher via GitGitGadget
2026-11-20 17:54 ` Ben Knoble [this message]
2026-11-20 18:08   ` Junio C Hamano
2026-11-20 18:35 ` [PATCH v2] " Ophir Bleicher via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=93127462-BCFD-4086-B19D-4B640F515140@gmail.com \
    --to=ben.knoble@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=ophirble@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox