Re: [PATCH] t4150: remove unused variable

[Phillip Wood <phillip.wood123@gmail.com>]

On 12/03/2019 14:38, Andrei Rybak wrote:
> In commit 735285b403 ("am: fix signoff when other trailers are present",
> 2017-08-08) tests using variable $signoff were rewritten and it is no
> longer used, so just remove it from the test setup.

Well spotted, thanks

Phillip

> Signed-off-by: Andrei Rybak <rybak.a.v@gmail.com>
> ---
>   t/t4150-am.sh | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/t/t4150-am.sh b/t/t4150-am.sh
> index 55b577d919..3f7f750cc8 100755
> --- a/t/t4150-am.sh
> +++ b/t/t4150-am.sh
> @@ -77,14 +77,12 @@ test_expect_success 'setup: messages' '
>   
>   	printf "Subject: " >subject-prefix &&
>   
> -	cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF &&
> +	cat - subject-prefix msg-without-scissors-line >msg-with-scissors-line <<-\EOF
>   	This line should not be included in the commit message with --scissors enabled.
>   
>   	 - - >8 - - remove everything above this line - - >8 - -
>   
>   	EOF
> -
> -	signoff="Signed-off-by: $GIT_COMMITTER_NAME <$GIT_COMMITTER_EMAIL>"
>   '
>   
>   test_expect_success setup '
>