From: "Felipe Contreras" <felipe.contreras@gmail.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] fast-import: add special mode; copy from parent.
Date: Mon, 22 Dec 2008 04:23:46 +0200 [thread overview]
Message-ID: <94a0d4530812211823l78d86e1en8e19872ee7efef23@mail.gmail.com> (raw)
In-Reply-To: <20081221220757.GA17355@spearce.org>
On Mon, Dec 22, 2008 at 12:07 AM, Shawn O. Pearce <spearce@spearce.org> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> + if (!prefixcmp(p, "- ")) {
>> + mode = 0;
>> + p += 2;
>
> This part made me wonder, why are we always doing "S_IFREG | mode"
> further down?
My guess is because 0644 and 0755; doing S_IFREG | mode doesn't
achieve anything for the other modes.
I just sent a patch that I hope makes that more visible.
--
Felipe Contreras
next prev parent reply other threads:[~2008-12-22 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 2:11 [PATCH 1/2] fast-import: add special mode; copy from parent Felipe Contreras
2008-12-21 2:11 ` [PATCH 2/2] fast-import: add special '-' blob reference to use the previous one Felipe Contreras
2008-12-21 22:11 ` Shawn O. Pearce
2008-12-21 22:24 ` Junio C Hamano
2008-12-21 22:33 ` Shawn O. Pearce
2008-12-22 2:10 ` Felipe Contreras
2008-12-22 2:08 ` Felipe Contreras
2008-12-21 22:07 ` [PATCH 1/2] fast-import: add special mode; copy from parent Shawn O. Pearce
2008-12-22 2:23 ` Felipe Contreras [this message]
2008-12-22 2:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530812211823l78d86e1en8e19872ee7efef23@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).