From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] config: Add new option to open an editor.
Date: Wed, 4 Feb 2009 17:03:22 +0200 [thread overview]
Message-ID: <94a0d4530902040703u53a9082fsfa7203b6203bd118@mail.gmail.com> (raw)
In-Reply-To: <20090204145317.GA5712@sigill.intra.peff.net>
On Wed, Feb 4, 2009 at 4:53 PM, Jeff King <peff@peff.net> wrote:
> On Wed, Feb 04, 2009 at 12:40:26AM +0200, Felipe Contreras wrote:
>
>> + } else if (!strcmp(argv[1], "--edit") || !strcmp(argv[1], "-e")) {
>> + char *config_filename;
>> + if (config_exclusive_filename)
>> + config_filename = xstrdup(config_exclusive_filename);
>> + else
>> + config_filename = git_pathdup("config");
>> + launch_editor(config_filename, NULL, NULL);
>> + free(config_filename);
>> + return 0;
>> } else
>
> With this patch, won't I get different behavior from:
>
> git config -e --global
>
> versus
>
> git config --global -e
Just like you get different behavior from:
git config -l --global
and
git config --global -l
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-04 15:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 22:40 [PATCH] config: Add new option to open an editor Felipe Contreras
2009-02-03 22:53 ` Johannes Schindelin
2009-02-03 22:56 ` Felipe Contreras
2009-02-03 23:05 ` Johannes Schindelin
2009-02-03 23:25 ` Felipe Contreras
2009-02-03 23:26 ` Felipe Contreras
2009-02-03 23:31 ` Johannes Schindelin
2009-02-03 23:43 ` Felipe Contreras
2009-02-04 14:53 ` Jeff King
2009-02-04 15:03 ` Felipe Contreras [this message]
2009-02-04 15:18 ` Jeff King
2009-02-04 15:41 ` Felipe Contreras
2009-02-04 22:34 ` [PATCH v3] " Felipe Contreras
2009-02-04 23:16 ` Junio C Hamano
2009-02-04 23:39 ` Felipe Contreras
2009-02-04 23:43 ` Johannes Schindelin
2009-02-04 23:49 ` Johannes Schindelin
2009-02-07 21:09 ` Felipe Contreras
2009-02-07 21:14 ` Johannes Schindelin
2009-02-07 21:15 ` Felipe Contreras
2009-02-07 21:34 ` Junio C Hamano
2009-02-07 21:50 ` Felipe Contreras
2009-02-07 21:53 ` [PATCH] " Felipe Contreras
2009-02-04 15:20 ` Johannes Schindelin
2009-02-04 15:42 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902040703u53a9082fsfa7203b6203bd118@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).