From: Felipe Contreras <felipe.contreras@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v3] config: Add new option to open an editor.
Date: Sat, 7 Feb 2009 23:09:49 +0200 [thread overview]
Message-ID: <94a0d4530902071309l7c34945ana2af31e41707fa0c@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902050049240.10279@pacific.mpi-cbg.de>
On Thu, Feb 5, 2009 at 1:49 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Thu, 5 Feb 2009, Johannes Schindelin wrote:
>
>> On Wed, 4 Feb 2009, Junio C Hamano wrote:
>>
>> > Felipe Contreras <felipe.contreras@gmail.com> writes:
>> >
>> > > The idea was originated by discussion about usability of manually
>> > > editing the config file in 'special needs' systems such as Windows. Now
>> > > the user can forget a bit about where the config files actually are.
>> >
>> > Does this honor core.editor setting in existing configuration files?
>>
>> It should, as it uses launch_editor().
>
> Oh, I see that launch_editor() does not do its own git_config() parsing.
> Dunno if it should...
I think it should, how expensive would it be to call
git_config(git_default_config, NULL) when it has been loaded already?
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-07 21:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 22:40 [PATCH] config: Add new option to open an editor Felipe Contreras
2009-02-03 22:53 ` Johannes Schindelin
2009-02-03 22:56 ` Felipe Contreras
2009-02-03 23:05 ` Johannes Schindelin
2009-02-03 23:25 ` Felipe Contreras
2009-02-03 23:26 ` Felipe Contreras
2009-02-03 23:31 ` Johannes Schindelin
2009-02-03 23:43 ` Felipe Contreras
2009-02-04 14:53 ` Jeff King
2009-02-04 15:03 ` Felipe Contreras
2009-02-04 15:18 ` Jeff King
2009-02-04 15:41 ` Felipe Contreras
2009-02-04 22:34 ` [PATCH v3] " Felipe Contreras
2009-02-04 23:16 ` Junio C Hamano
2009-02-04 23:39 ` Felipe Contreras
2009-02-04 23:43 ` Johannes Schindelin
2009-02-04 23:49 ` Johannes Schindelin
2009-02-07 21:09 ` Felipe Contreras [this message]
2009-02-07 21:14 ` Johannes Schindelin
2009-02-07 21:15 ` Felipe Contreras
2009-02-07 21:34 ` Junio C Hamano
2009-02-07 21:50 ` Felipe Contreras
2009-02-07 21:53 ` [PATCH] " Felipe Contreras
2009-02-04 15:20 ` Johannes Schindelin
2009-02-04 15:42 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902071309l7c34945ana2af31e41707fa0c@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).