From: Felipe Contreras <felipe.contreras@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Gerrit Pape <pape@smarden.org>
Subject: Re: [PATCH v2 1/8] config: Trivial rename in preparation for parseopt.
Date: Tue, 17 Feb 2009 15:59:28 +0200 [thread overview]
Message-ID: <94a0d4530902170559r74d0b9acyea9be124ece0adeb@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0902171300450.6185@intel-tinevez-2-302>
On Tue, Feb 17, 2009 at 2:01 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Tue, 17 Feb 2009, Felipe Contreras wrote:
>
>> free(repo_config);
>> + if (found == 0)
>> + error("no config file found");
>> return ret;
>
> Err, you mean "return error(..)"?
>
> But it might be not an error at all: think of "cd / && git ls-remote $URL"
> without /etc/gitconfig nor $HOME/.gitconfig.
Yeah, I thought about that when doing the patch. I've removed the
error(), now it will only return -1. Almost nobody is checking the
return code anyways.
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-17 14:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-17 0:54 [PATCH v2 1/8] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 2/8] config: Reorganize get_color* Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 3/8] config: Use parseopt Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 4/8] config: Disallow multiple variable types Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 5/8] config: Disallow multiple config file locations Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 6/8] config: Don't allow extra arguments for -e or -l Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 7/8] config: Codestyle cleanups Felipe Contreras
2009-02-17 0:54 ` [PATCH v2 8/8] config: Cleanup editor action Felipe Contreras
2009-02-17 2:28 ` Junio C Hamano
2009-02-17 2:24 ` [PATCH v2 4/8] config: Disallow multiple variable types Junio C Hamano
2009-02-17 2:24 ` [PATCH v2 3/8] config: Use parseopt Junio C Hamano
2009-02-17 13:55 ` Felipe Contreras
2009-02-17 5:44 ` Junio C Hamano
2009-02-17 10:35 ` Felipe Contreras
2009-02-17 11:55 ` Johannes Schindelin
2009-02-17 13:21 ` Felipe Contreras
2009-02-17 1:00 ` [PATCH v2 2/8] config: Reorganize get_color* Felipe Contreras
2009-02-17 2:24 ` Junio C Hamano
2009-02-17 1:45 ` [PATCH v2 1/8] config: Trivial rename in preparation for parseopt Junio C Hamano
2009-02-17 2:42 ` Felipe Contreras
2009-02-17 12:01 ` Johannes Schindelin
2009-02-17 13:59 ` Felipe Contreras [this message]
2009-02-17 9:00 ` Gerrit Pape
2009-02-17 11:58 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902170559r74d0b9acyea9be124ece0adeb@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).