From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH B v4 1/5] git config: reorganize to use parseopt
Date: Sun, 22 Feb 2009 19:19:07 +0200 [thread overview]
Message-ID: <94a0d4530902220919t729915dleed932b010ee76b@mail.gmail.com> (raw)
In-Reply-To: <7vskm62z9w.fsf@gitster.siamese.dyndns.org>
On Sun, Feb 22, 2009 at 6:48 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> + else if (actions == ACTION_GET_COLORBOOL) {
>> + if (argc == 1)
>> + stdout_is_tty = git_config_bool("command line", argv[0]);
>> + else if (argc == 0)
>> + stdout_is_tty = isatty(1);
>> + return get_colorbool(argc != 0);
>> + }
>
> I see you fixed this from the last series...
Yes, argc != 1 was wrong. Now I've made sure all the tests pass.
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-22 17:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 0:49 [PATCH B v4 0/5] git config: reorganization Felipe Contreras
2009-02-21 0:49 ` [PATCH B v4 1/5] git config: reorganize to use parseopt Felipe Contreras
2009-02-21 0:49 ` [PATCH B v4 2/5] git config: don't allow multiple config file locations Felipe Contreras
2009-02-21 0:49 ` [PATCH B v4 3/5] git config: don't allow multiple variable types Felipe Contreras
2009-02-21 0:49 ` [PATCH B v4 4/5] git config: don't allow extra arguments for -e or -l Felipe Contreras
2009-02-21 0:49 ` [PATCH B v4 5/5] git config: don't allow --get-color* and variable type Felipe Contreras
2009-02-22 16:48 ` Junio C Hamano
2009-02-22 17:12 ` Felipe Contreras
2009-02-22 17:35 ` Junio C Hamano
2009-03-07 9:47 ` Felipe Contreras
2009-02-22 16:48 ` [PATCH B v4 1/5] git config: reorganize to use parseopt Junio C Hamano
2009-02-22 17:19 ` Felipe Contreras [this message]
2009-02-21 0:53 ` [PATCH B v4 0/5] git config: reorganization Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902220919t729915dleed932b010ee76b@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).