From: Felipe Contreras <felipe.contreras@gmail.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH/RFC 5/6] builtin-tag: add sort by date -D
Date: Sun, 22 Feb 2009 20:38:10 +0200 [thread overview]
Message-ID: <94a0d4530902221038j6614bfacl223c0fa7b7be396@mail.gmail.com> (raw)
In-Reply-To: <e29894ca0902221006j3d602553x15807b41698f51a1@mail.gmail.com>
On Sun, Feb 22, 2009 at 8:06 PM, Marc-André Lureau
<marcandre.lureau@gmail.com> wrote:
> Signed-off-by: Marc-Andre Lureau <marcandre.lureau@gmail.com>
> ---
> builtin-tag.c | 162 +++++++++++++++++++++++++++++++++++++++++++++------------
> 1 files changed, 129 insertions(+), 33 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 01e7374..8ff9d03 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -16,7 +16,7 @@
> static const char * const git_tag_usage[] = {
> "git tag [-a|-s|-u <key-id>] [-f] [-m <msg>|-F <file>] <tagname> [<head>]",
> "git tag -d <tagname>...",
> - "git tag -l [-n[<num>]] [<pattern>]",
> + "git tag -l [-n[<num>] -D] [<pattern>]",
> "git tag -v <tagname>...",
> NULL
> };
Hmm, the -D option is independent of -n, so "[-D]". Also, it must be documented.
<snip/>
Wouldn't it make sense to split this patch so the first part adds the
option to filter, even if there are not filters functional, and the
second one adds the date filter?
--
Felipe Contreras
prev parent reply other threads:[~2009-02-22 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 18:06 [PATCH/RFC 5/6] builtin-tag: add sort by date -D Marc-André Lureau
2009-02-22 18:33 ` Junio C Hamano
2009-02-22 18:38 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902221038j6614bfacl223c0fa7b7be396@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=marcandre.lureau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).