From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH] revision.c: add --format option for 'git log'
Date: Sun, 22 Feb 2009 20:55:46 +0200 [thread overview]
Message-ID: <94a0d4530902221055g4e815a78oc0aa094304588ab7@mail.gmail.com> (raw)
In-Reply-To: <7vbpsuxqpo.fsf@gitster.siamese.dyndns.org>
On Sun, Feb 22, 2009 at 8:37 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> I understand the option should be kept for people that are used to it,
>
> It is not just that. New people should learn existing lingo, as that is
> the word used in the existing documentation and various random web pages,
> so that they can use the same language when they teach people who are
> newer than themselves.
Yes, but the existing lingo is not perfect... I'm proposing this
particular lingo to be changed.
> If the existing word was not pretty (that came from "pretty-formatting")
> but something unpronouncible like '--gzxfw=short", then your argument
> might make some sense, but there is no such "breakage we need to fix"
> here.
It's not breakage that needs to be fixed, it's UI improvement, and one
guideline is that the interface needs to be intuitive and natural
(when possible). IMO pretty > gzxfw, but format > pretty. Don't you
think that --format=email is more natural than --pretty=email? I think
you are holding a bit too tight on the code reason why it's called
--pretty, but users shouldn't need to see the code in order to
understand why the naming of the options in git commands make sense.
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-22 18:57 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 15:26 [RFC/PATCH] revision.c: add --format option for 'git log' Felipe Contreras
2009-02-22 16:49 ` Junio C Hamano
2009-02-22 17:18 ` Felipe Contreras
2009-02-22 17:53 ` Junio C Hamano
2009-02-22 18:06 ` Junio C Hamano
2009-02-22 18:14 ` Felipe Contreras
2009-02-22 18:37 ` Junio C Hamano
2009-02-22 18:55 ` Felipe Contreras [this message]
2009-02-23 6:39 ` Junio C Hamano
2009-02-24 0:56 ` Felipe Contreras
2009-02-24 1:03 ` Felipe Contreras
2009-02-24 1:33 ` Junio C Hamano
2009-02-24 1:55 ` Nanako Shiraishi
2009-02-24 8:00 ` Junio C Hamano
2009-02-24 9:34 ` Felipe Contreras
2009-02-24 4:06 ` [PATCH] Add --format that is a synonym to --pretty Nanako Shiraishi
2009-02-24 4:50 ` Jeff King
2009-02-24 5:33 ` Junio C Hamano
2009-02-24 5:45 ` Jeff King
2009-02-24 9:59 ` [PATCH 0/3] --format, --pretty and --oneline Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 1/3] Add --format that is a synonym to --pretty Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 2/3] Give short-hands to --pretty=tformat:%formatstring Nanako Shiraishi
2009-02-24 9:59 ` [PATCH 3/3] Add --oneline that is a synonym to "--pretty=oneline --abbrev-commit" Nanako Shiraishi
2009-02-24 17:38 ` Junio C Hamano
2009-02-24 21:06 ` [PATCH] Add tests for git log --pretty, --format and --oneline Felipe Contreras
2009-02-25 9:54 ` Junio C Hamano
2009-02-25 9:57 ` Jeff King
2009-02-25 10:16 ` Junio C Hamano
2009-02-25 10:20 ` Jeff King
2009-02-24 11:02 ` [PATCH] bash completion: add --format= and --oneline options for "git log" Teemu Likonen
2009-02-24 13:33 ` [PATCH v2] " Teemu Likonen
2009-02-24 15:39 ` Shawn O. Pearce
2009-02-24 15:47 ` Teemu Likonen
2009-02-24 15:57 ` Shawn O. Pearce
2009-02-24 16:14 ` Teemu Likonen
2009-02-27 18:53 ` Teemu Likonen
2009-02-24 8:35 ` [RFC/PATCH] revision.c: add --format option for 'git log' Felipe Contreras
2009-02-22 20:34 ` Linus Torvalds
2009-02-22 22:12 ` Jakub Narebski
2009-02-23 9:55 ` Wincent Colaiuta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902221055g4e815a78oc0aa094304588ab7@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).