From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH RESEND] Fix a bunch of pointer declarations (codestyle)
Date: Wed, 25 Feb 2009 12:02:25 +0200 [thread overview]
Message-ID: <94a0d4530902250202rb12a4e7leb9856258dafc488@mail.gmail.com> (raw)
In-Reply-To: <7veixnaqrn.fsf@gitster.siamese.dyndns.org>
On Wed, Feb 25, 2009 at 10:02 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> This applies on top of the 'next' branch.
>>
>> alias.c | 4 +-
>> alloc.c | 2 +-
>> attr.c | 4 +-
>> builtin-blame.c | 8 +++---
>> builtin-checkout-index.c | 4 +-
>> builtin-describe.c | 4 +-
>> builtin-fetch-pack.c | 2 +-
>> builtin-help.c | 6 ++--
>> builtin-update-index.c | 6 ++--
>> cache.h | 2 +-
>> combine-diff.c | 4 +-
>> compat/mingw.c | 2 +-
>> config.c | 30 ++++++++++++++--------------
>> contrib/convert-objects/convert-objects.c | 6 ++--
>> diff-no-index.c | 2 +-
>> diff.c | 6 ++--
>> dir.c | 2 +-
>> fast-import.c | 14 ++++++------
>> git.c | 8 +++---
>> http.c | 4 +-
>> lockfile.c | 2 +-
>> reflog-walk.c | 2 +-
>> run-command.c | 2 +-
>> server-info.c | 4 +-
>> sha1_file.c | 2 +-
>> wt-status.c | 2 +-
>
> Sorry, but I cannot take this as is.
>
> These trivial clean-ups are welcome either as part of a preparatory
> clean-up before starting to work in the area of code you are touching, or
> as a standalone patch to files that nobody is currently working on.
>
> There is a huge overlap between "git diff --name-only master..pu" and the
> above list, so it is impossible for me to take the patch and I cannot
> afford the time to sift through gems out of stones.
It's understandable. Would there be a better time to send this patch?
After 1.6.2, or in a different form?
--
Felipe Contreras
next prev parent reply other threads:[~2009-02-25 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-24 21:59 [PATCH RESEND] Fix a bunch of pointer declarations (codestyle) Felipe Contreras
2009-02-24 21:59 ` [PATCH] git add: trivial codestyle cleanup Felipe Contreras
2009-02-24 21:59 ` [PATCH] git config: improve documentation Felipe Contreras
2009-02-24 21:59 ` [PATCH] sha1_file.c: fix typo Felipe Contreras
2009-02-25 8:03 ` [PATCH] git config: improve documentation Junio C Hamano
2009-02-25 19:52 ` Johannes Schindelin
2009-05-01 9:09 ` Felipe Contreras
2009-02-25 9:54 ` [PATCH] git add: trivial codestyle cleanup Junio C Hamano
2009-02-25 8:02 ` [PATCH RESEND] Fix a bunch of pointer declarations (codestyle) Junio C Hamano
2009-02-25 10:02 ` Felipe Contreras [this message]
2009-02-25 10:14 ` Junio C Hamano
2009-03-07 10:41 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530902250202rb12a4e7leb9856258dafc488@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).