From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/3] config: set help text for --bool-or-int
Date: Sat, 7 Mar 2009 23:07:46 +0200 [thread overview]
Message-ID: <94a0d4530903071307p46092810rb1637bfc853ee4d1@mail.gmail.com> (raw)
In-Reply-To: <1236446046-18319-3-git-send-email-peff@peff.net>
On Sat, Mar 7, 2009 at 7:14 PM, Jeff King <peff@peff.net> wrote:
> The conversion to parse_opt left this as NULL; on glibc
> systems, the usage message prints
>
> --bool-or-int (null)
>
> and on other ones, segfaults.
Shouldn't then OPT_BIT make sure there is no crash?
I was surprised when it didn't complain. I thought on making it "" but
I wanted to make it visible that there was no documentation for that,
which is the reason I left it that way.
--
Felipe Contreras
next prev parent reply other threads:[~2009-03-07 21:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-07 17:14 [PATCH 0/3] config --bool-or-int fixes Jeff King
2009-03-07 17:14 ` [PATCH 1/3] t1300: use test_must_fail as appropriate Jeff King
2009-03-07 17:14 ` [PATCH 2/3] config: set help text for --bool-or-int Jeff King
2009-03-07 21:07 ` Felipe Contreras [this message]
2009-03-07 22:48 ` Jeff King
2009-03-09 21:50 ` Felipe Contreras
2009-03-10 17:59 ` Jeff King
2009-03-07 17:14 ` [PATCH 3/3] document config --bool-or-int Jeff King
2009-03-07 17:16 ` [PATCH 0/3] config --bool-or-int fixes Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530903071307p46092810rb1637bfc853ee4d1@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).