From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Carlos Rica <jasampler@gmail.com>,
git@vger.kernel.org, johannes.schindelin@gmx.de
Subject: Re: [PATCH] config: --replace-all with one argument exits properly with a better message.
Date: Sat, 14 Mar 2009 23:34:55 +0200 [thread overview]
Message-ID: <94a0d4530903141434w2fb8aa28we087465482a12e41@mail.gmail.com> (raw)
In-Reply-To: <7vtz5vakrp.fsf@gitster.siamese.dyndns.org>
On Sat, Mar 14, 2009 at 10:53 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Carlos Rica <jasampler@gmail.com> writes:
>
>> 'config --replace-all ONE_ARG' was being treated as 'config NAME VALUE',
>> showing the error "key does not contain a section: --replace-all".
>
> Hmm, I am getting "error: wrong number of arguments" followed by the long
> and somewhat annoying "usage" from the parseopt table dump.
If you find it annoying why don't you remove the usage?
> Ahh, that is because I am running the version from 'next', which contains
> the fc/parseopt-config topic that rewrites the option parser and error
> checking almost completely.
>
> Can you work with Felipe to see if this is still needed, or needs to be
> fixed in a different way? It could be that your tests may already pass
> over there on 'next'. I didn't check.
The new code is already checking correctly that --replace-all needs at
least two arguments. However, the "usage" is incorrect and of course
the test will come in handy.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2009-03-14 21:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 2:42 [PATCH] config: --replace-all with one argument exits properly with a better message Carlos Rica
2009-03-14 20:53 ` Junio C Hamano
2009-03-14 21:34 ` Felipe Contreras [this message]
2009-03-15 1:53 ` Junio C Hamano
2009-03-15 10:26 ` Felipe Contreras
2009-03-16 14:41 ` Carlos Rica
2009-03-16 15:25 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530903141434w2fb8aa28we087465482a12e41@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasampler@gmail.com \
--cc=johannes.schindelin@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).