From: Felipe Contreras <felipe.contreras@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Carlos Rica <jasampler@gmail.com>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] config: test for --replace-all with one argument and fix documentation.
Date: Tue, 17 Mar 2009 12:41:29 +0200 [thread overview]
Message-ID: <94a0d4530903170341g27f215d4t8c3ad25e7f362590@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0903171123530.6393@intel-tinevez-2-302>
On Tue, Mar 17, 2009 at 12:24 PM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
> Hi,
>
> On Tue, 17 Mar 2009, Carlos Rica wrote:
>
>> Option --replace-all only allows at least two arguments, so
>> documentation was needing to be updated accordingly. A test showing
>> that the command fails with only one parameter is also provided.
>>
>> Signed-off-by: Carlos Rica <jasampler@gmail.com>
>
> Looks obviously correct to me. I am actually unsure if I can ACK this
> patch, as most of builtin-config.c does not look all that familiar to me
> anymore ;-)
Hehe... interesting, my first possibility of ack'ing :D (I guess)
Acked-by: Felipe Contreras <felipe.contreras@gmail.com>
--
Felipe Contreras
next prev parent reply other threads:[~2009-03-17 10:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-17 9:46 [PATCH] config: test for --replace-all with one argument and fix documentation Carlos Rica
2009-03-17 10:24 ` Johannes Schindelin
2009-03-17 10:41 ` Felipe Contreras [this message]
2009-03-17 11:02 ` Uwe Kleine-König
2009-03-17 11:12 ` Carlos Rica
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530903170341g27f215d4t8c3ad25e7f362590@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jasampler@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).