From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [RFC/PATCH 1/8] user-manual: remove some git-foo usage
Date: Mon, 23 Mar 2009 12:54:30 +0200 [thread overview]
Message-ID: <94a0d4530903230354x3a37cf56oe3862c2b7c37a8d4@mail.gmail.com> (raw)
In-Reply-To: <20090323063141.GA1119@coredump.intra.peff.net>
On Mon, Mar 23, 2009 at 8:31 AM, Jeff King <peff@peff.net> wrote:
> On Sun, Mar 22, 2009 at 08:05:14PM +0200, Felipe Contreras wrote:
>
>> Every commit has a 40-hexdigit id, sometimes called the "object name" or the
>> -"SHA1 id", shown on the first line of the "git-show" output. You can usually
>> +"SHA1 id", shown on the first line of the "git show" output. You can usually
>
> I think some of these were intentionally left in the original mass
> dashes to spaces conversion. The intent was that one could use the
> git-show form in talking about the command in text.
>
> However, I think I actually prefer the version given by your patch. I
> just wanted to point out that this is a decision to change how we
> mention these in the documentation and not simply a fix for things that
> got missed in the conversion. Others may disagree on how it looks.
>
> It seems like you added monospace backticks in most locations. Is there
> a reason not to standardize on that and use `git show` here?
>
>> [[Updating-a-repository-With-git-fetch]]
>> -Updating a repository with git-fetch
>> +Updating a repository with git fetch
>> ------------------------------------
>
> I think this one should probably be `git fetch`.
A subsequent patch is adding the monospace backticks and a lot more
quotation stuff.
In this patch I tried to focus on git-foo, and add the backticks only
when there are no delimiters, so I replaced "git-foo" with "git foo"
and git-foo with `git foo`. I also didn't add backticks on the titles
because I thought it was a bit controversial and was probably better
in a separate patch.
Cheers.
--
Felipe Contreras
prev parent reply other threads:[~2009-03-23 10:56 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-22 18:05 [RFC/PATCH 0/8] user-manual: style improvements Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 2/8] docbook: improve css style Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 3/8] docbook: radical style change Felipe Contreras
[not found] ` <1237745121-6325-5-git-send-email-felipe.contreras@gmail.com>
2009-03-22 18:05 ` [RFC/PATCH 5/8] user-manual: use 'fast-forward' instead of 'fast forward' Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 6/8] user-manual: use SHA-1 instead of SHA1 or sha1 Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 7/8] user-manual: add global config section Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 8/8] user-manual: simplify the user configuration Felipe Contreras
2009-03-22 22:42 ` Wincent Colaiuta
2009-03-22 23:01 ` Felipe Contreras
2009-03-23 0:00 ` Junio C Hamano
2009-03-23 11:02 ` Felipe Contreras
2009-03-23 0:07 ` Wincent Colaiuta
2009-03-23 11:07 ` Felipe Contreras
2009-03-23 11:09 ` Wincent Colaiuta
2009-03-24 0:22 ` Felipe Contreras
2009-03-24 21:52 ` [RFC/PATCH 7/8] user-manual: add global config section J. Bruce Fields
2009-03-24 22:17 ` Felipe Contreras
2009-03-24 22:42 ` J. Bruce Fields
2009-03-23 6:50 ` [RFC/PATCH 3/8] docbook: radical style change Jeff King
2009-03-23 10:47 ` Felipe Contreras
2009-03-23 6:42 ` [RFC/PATCH 2/8] docbook: improve css style Jeff King
2009-03-23 10:31 ` Felipe Contreras
2009-03-23 15:20 ` Michael J Gruber
2009-03-24 0:21 ` Felipe Contreras
2009-03-24 2:08 ` Junio C Hamano
2009-03-24 7:52 ` Felipe Contreras
2009-03-24 8:18 ` Jeff King
2009-03-24 8:57 ` Felipe Contreras
2009-03-24 9:00 ` Jeff King
2009-03-24 9:39 ` Felipe Contreras
2009-03-24 8:29 ` Michael J Gruber
2009-03-24 9:06 ` Felipe Contreras
2009-03-24 9:16 ` Jeff King
2009-03-24 10:39 ` Michael J Gruber
2009-03-24 10:52 ` Felipe Contreras
2009-03-24 0:20 ` Felipe Contreras
2009-03-24 8:42 ` Jeff King
2009-03-23 6:31 ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Jeff King
2009-03-23 10:54 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530903230354x3a37cf56oe3862c2b7c37a8d4@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).