git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [RFC/PATCH 2/8] docbook: improve css style
Date: Tue, 24 Mar 2009 11:06:50 +0200	[thread overview]
Message-ID: <94a0d4530903240206k6eecdabg2cbb2c5595cd4bc@mail.gmail.com> (raw)
In-Reply-To: <49C899E1.6060809@drmicha.warpmail.net>

On Tue, Mar 24, 2009 at 10:29 AM, Michael J Gruber
<git@drmicha.warpmail.net> wrote:
> Felipe Contreras venit, vidit, dixit 24.03.2009 01:21:
>> On Mon, Mar 23, 2009 at 5:20 PM, Michael J Gruber
>> <git@drmicha.warpmail.net> wrote:
>>> Felipe Contreras venit, vidit, dixit 23.03.2009 11:31:
>>>> On Mon, Mar 23, 2009 at 8:42 AM, Jeff King <peff@peff.net> wrote:
>>>>> On Sun, Mar 22, 2009 at 08:05:15PM +0200, Felipe Contreras wrote:
>>>>>
>>>>>>  tt.literal, code.literal {
>>>>>>    color: navy;
>>>>>> +  font-size: 1em;
>>>>>> +}
>>>>>
>>>>> Isn't 1em already the default size? Or are you trying to override some
>>>>> other size specification elsewhere? It's hard to tell what the goal is
>>>>> because your commit message merely says "improve".
>>>>
>>>> That's correct.
>>>>
>>>> The problem is that when the user has a different size for the
>>>> sans-serif and monospace fonts it looks horrible when they are on the
>>>> same paragraph. I thought 1em did the trick, but you are right, it
>>>> doesn't.
>>>>
>>>> It looks like the only way to fix this is to set absolute sizes.
>>>>
>>>
>>> Also, it seems that everything which is not black is blue, except for
>>> terms, which are green and slanted. I don't think that looks nice
>>> together. How about slanted blue?
>>
>> What's wrong with having 2 colors?
>
> I don't mind having 2, they just don't look good together over here, on
> my screen and to my eyes...
>
> Right now we have "plain old asciidoc look" which doesn't look that old
> after all. You pointed out a deficiency, and I'm all for fixing it. I
> just think that introducing new colors is something that may require a
> ground up rethinking of the theme being used: make it informative but
> unobtrusive. Also, I'm against over-emphasizing: use slanted or a
> specific color, but not both. Unless one color means emphasizing and
> slanted means file, for example.

Take a look at:
http://people.freedesktop.org/~felipec/git/user-manual.html#bisect-merges

Do you think slanting Z (and the other characters) is enough to emphasize it?

-- 
Felipe Contreras

  reply	other threads:[~2009-03-24  9:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-22 18:05 [RFC/PATCH 0/8] user-manual: style improvements Felipe Contreras
2009-03-22 18:05 ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Felipe Contreras
2009-03-22 18:05   ` [RFC/PATCH 2/8] docbook: improve css style Felipe Contreras
2009-03-22 18:05     ` [RFC/PATCH 3/8] docbook: radical style change Felipe Contreras
     [not found]       ` <1237745121-6325-5-git-send-email-felipe.contreras@gmail.com>
2009-03-22 18:05         ` [RFC/PATCH 5/8] user-manual: use 'fast-forward' instead of 'fast forward' Felipe Contreras
2009-03-22 18:05           ` [RFC/PATCH 6/8] user-manual: use SHA-1 instead of SHA1 or sha1 Felipe Contreras
2009-03-22 18:05             ` [RFC/PATCH 7/8] user-manual: add global config section Felipe Contreras
2009-03-22 18:05               ` [RFC/PATCH 8/8] user-manual: simplify the user configuration Felipe Contreras
2009-03-22 22:42                 ` Wincent Colaiuta
2009-03-22 23:01                   ` Felipe Contreras
2009-03-23  0:00                     ` Junio C Hamano
2009-03-23 11:02                       ` Felipe Contreras
2009-03-23  0:07                     ` Wincent Colaiuta
2009-03-23 11:07                       ` Felipe Contreras
2009-03-23 11:09                         ` Wincent Colaiuta
2009-03-24  0:22                           ` Felipe Contreras
2009-03-24 21:52               ` [RFC/PATCH 7/8] user-manual: add global config section J. Bruce Fields
2009-03-24 22:17                 ` Felipe Contreras
2009-03-24 22:42                   ` J. Bruce Fields
2009-03-23  6:50       ` [RFC/PATCH 3/8] docbook: radical style change Jeff King
2009-03-23 10:47         ` Felipe Contreras
2009-03-23  6:42     ` [RFC/PATCH 2/8] docbook: improve css style Jeff King
2009-03-23 10:31       ` Felipe Contreras
2009-03-23 15:20         ` Michael J Gruber
2009-03-24  0:21           ` Felipe Contreras
2009-03-24  2:08             ` Junio C Hamano
2009-03-24  7:52               ` Felipe Contreras
2009-03-24  8:18                 ` Jeff King
2009-03-24  8:57                   ` Felipe Contreras
2009-03-24  9:00                     ` Jeff King
2009-03-24  9:39                       ` Felipe Contreras
2009-03-24  8:29             ` Michael J Gruber
2009-03-24  9:06               ` Felipe Contreras [this message]
2009-03-24  9:16                 ` Jeff King
2009-03-24 10:39                 ` Michael J Gruber
2009-03-24 10:52                   ` Felipe Contreras
2009-03-24  0:20       ` Felipe Contreras
2009-03-24  8:42         ` Jeff King
2009-03-23  6:31   ` [RFC/PATCH 1/8] user-manual: remove some git-foo usage Jeff King
2009-03-23 10:54     ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530903240206k6eecdabg2cbb2c5595cd4bc@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).