git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	Michael J Gruber <git@drmicha.warpmail.net>,
	git@vger.kernel.org
Subject: Re: [PATCH 1/2] Documentation: replace sha1 by SHA-1
Date: Sat, 25 Apr 2009 13:47:42 +0300	[thread overview]
Message-ID: <94a0d4530904250347s55a66f47gbaaf5ea42d0c4eac@mail.gmail.com> (raw)
In-Reply-To: <7vzle5ad8n.fsf@gitster.siamese.dyndns.org>

On Sat, Apr 25, 2009 at 1:38 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jeff King <peff@peff.net> writes:
>
>> On Fri, Apr 24, 2009 at 04:49:34PM +0200, Michael J Gruber wrote:
>>
>>> --- a/Documentation/git-cat-file.txt
>>> +++ b/Documentation/git-cat-file.txt
>>> @@ -76,7 +76,7 @@ If '--batch' is specified, output of the following form is printed for each
>>>  object specified on stdin:
>>>
>>>  ------------
>>> -<sha1> SP <type> SP <size> LF
>>> +<SHA-1> SP <type> SP <size> LF
>>>  <contents> LF
>>>  ------------
>>
>> Maybe it is just me, but I find the original for this one easier to
>> read. Perhaps because <sha1> is really a variable name here (but for a
>> human reader to interpret instead of a compiler), so I find the
>> punctuation and capitalization distracting.
>>
>> I wonder if all <sha1> should simply be left as-is.
>
> Or spell them using their official terminology "object name".

Why is the "official" terminology "object name", wouldn't "id" work better?

SHA-1 is simply one hash function, what git has been referring to
"sha1" is actually the SHA-1 digest. This digest has been used as a
checksum (or hash sum) but also as a unique identifier, therefore "id"
would work just fine.

-- 
Felipe Contreras

  reply	other threads:[~2009-04-25 10:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 14:49 [PATCH 0/2] Unify use of [sha,SHA][,-]1 Michael J Gruber
2009-04-24 14:49 ` [PATCH 1/2] Documentation: replace sha1 by SHA-1 Michael J Gruber
2009-04-24 14:49   ` [PATCH 2/2] Documentation: replace SHA1 " Michael J Gruber
2009-04-24 21:30     ` Jeff King
2009-04-24 15:18   ` [PATCH 1/2] Documentation: replace sha1 " Johannes Sixt
2009-04-24 15:23     ` Wincent Colaiuta
2009-04-24 15:33       ` Michael J Gruber
2009-04-24 15:30     ` Michael J Gruber
2009-04-24 21:28   ` Jeff King
2009-04-24 22:38     ` Junio C Hamano
2009-04-25 10:47       ` Felipe Contreras [this message]
2009-04-25 12:13   ` Dmitry Potapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530904250347s55a66f47gbaaf5ea42d0c4eac@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).