From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/3] log: prettier decorations
Date: Thu, 14 May 2009 00:34:41 +0300 [thread overview]
Message-ID: <94a0d4530905131434q17743408p5bc4b1c2fc332ea@mail.gmail.com> (raw)
In-Reply-To: <20090513212812.GA21268@coredump.intra.peff.net>
On Thu, May 14, 2009 at 12:28 AM, Jeff King <peff@peff.net> wrote:
> On Thu, May 14, 2009 at 12:22:03AM +0300, Felipe Contreras wrote:
>
>> In order to do that I had to change prettify_ref to prettify_refname because
>> add_ref_decoration doesn't have the ref object.
>
> Thanks, this 1/3 looks fine to me.
>
> But:
>
>> Felipe Contreras (3):
>> Change prettify_ref to prettify_refname
>> Prettify log decorations even more
>> Fix test for new log decorate
>
> Shouldn't 2/3 and 3/3 just be squashed together? It looks like 3/3 fixes
> tests broken in 2/3, so you are hurting bisectability if they don't
> happen together.
Yeah, I thought so too. Maybe I should trust my instinct a bit more =P
> Other than that, I think the intent of the change and the implementation
> look fine.
Cool. I squashed them and re-sent.
--
Felipe Contreras
prev parent reply other threads:[~2009-05-13 21:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 21:22 [PATCH 0/3] log: prettier decorations Felipe Contreras
2009-05-13 21:22 ` [PATCH 1/3] Change prettify_ref to prettify_refname Felipe Contreras
2009-05-13 21:22 ` [PATCH 2/3] Prettify log decorations even more Felipe Contreras
2009-05-13 21:22 ` [PATCH 3/3] Fix test for new log decorate Felipe Contreras
2009-05-13 21:28 ` [PATCH 0/3] log: prettier decorations Jeff King
2009-05-13 21:32 ` [PATCH 2/2] Prettify log decorations even more Felipe Contreras
2009-05-13 21:34 ` Felipe Contreras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530905131434q17743408p5bc4b1c2fc332ea@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).