git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>,
	Nicolas Sebrecht <nicolas.s.dev@gmx.fr>,
	git@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Re: user-manual: general improvements
Date: Thu, 21 May 2009 19:00:17 +0300	[thread overview]
Message-ID: <94a0d4530905210900xa464f75se2bd2bf3d8103b10@mail.gmail.com> (raw)
In-Reply-To: <7vvdnubl1x.fsf@alter.siamese.dyndns.org>

On Thu, May 21, 2009 at 5:14 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>>> Maybe this was even discussed earlier in the thread (I didn't go back to
>>> look), but it should definitely be part of the commit message.
>>
>> The rule I followed is: change it to whatever looks best.
>
> "Looks best to me" is not something other people can follow to replicate
> the examples you set here to further "clean up" other parts of the
> documentation set or writing new sections to the document you touched up
> with this patch.
>
> I suspect that you would not deny the possibility of saying "The result
> looked better when I last looked at it, but now I think about it I do not
> know why I thought it looked better" three months down the line.
>
> It is not a rule.

The "guidelines" (not rules) I followed are a bit hard to explain,
I'll try to do that, but in the meantime would you deny that the patch
actually makes things a bit more consistent?

-- 
Felipe Contreras

  reply	other threads:[~2009-05-21 16:00 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 22:53 [PATCH v3 0/2] user-manual: general improvements Felipe Contreras
     [not found] ` <1241650416-12224-2-git-send-email-felipe.contreras@gmail.com>
2009-05-06 22:53   ` [PATCH v3 2/2] user-manual: use 'fast-forward' instead of 'fast forward' Felipe Contreras
2009-05-07  7:23 ` [PATCH v3 0/2] Re: user-manual: general improvements Nicolas Sebrecht
2009-05-08  0:04   ` Junio C Hamano
     [not found]     ` <20090508042814.GA30031@vidovic>
     [not found]       ` <94a0d4530905131430q2250a43ei692265c3f32b5715@mail.gmail.com>
     [not found]         ` <20090514160609.GA12910@vidovic>
2009-05-21  1:33           ` Junio C Hamano
2009-05-21  4:15             ` Jeff King
2009-05-21  5:18               ` Junio C Hamano
2009-05-21  7:17               ` Felipe Contreras
2009-05-21 13:18                 ` Nicolas Sebrecht
2009-05-21 15:47                   ` Felipe Contreras
2009-05-21 16:41                     ` Wincent Colaiuta
2009-05-21 13:25                 ` Michael J Gruber
2009-05-21 15:57                   ` Felipe Contreras
2009-05-25 12:41                     ` Michael J Gruber
2009-05-21 14:14                 ` Junio C Hamano
2009-05-21 16:00                   ` Felipe Contreras [this message]
2009-05-21 16:10                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530905210900xa464f75se2bd2bf3d8103b10@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=nicolas.s.dev@gmx.fr \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).