From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>,
"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH] Use 'fast-forward' all over the place
Date: Sun, 25 Oct 2009 12:06:16 +0300 [thread overview]
Message-ID: <94a0d4530910250206v4827941cs12b88ec75975224e@mail.gmail.com> (raw)
In-Reply-To: <7vtyxoymfa.fsf@alter.siamese.dyndns.org>
On Sun, Oct 25, 2009 at 10:15 AM, Junio C Hamano <gitster@pobox.com> wrote:
> I'll queue your patch with the following interdiff for now.
>
> * user-manual.txt: do not change emphasis (typography) in this patch---if
> it needs to be changed, that should be a separate patch.
>
> * builtin-fetch.c: an instance of "non fast-forward" was left
> unconverted; fix it.
>
> * contrib/hooks/post-receive-email: likewise.
>
> By the way, in Documentation/git-init.txt there also is another "non
> fast-forward"; since it is not a fix-up to this patch, I left it as-is.
> We may want to change it as well while we are at it.
>
> * git-gui: this is a straight revert of your patch, so that Shawn can
> apply an undated version of this patch to his tree first, and then I
> can pull the result from him.
>
> $ git grep -i -n -e 'fast forward' -- git-gui/
>
> will show what need to be changed. This is a key string of "mc", so
> msgid in *.po files and git-gui.pot file need to consistently change,
> even though the translated strings in *.po files may stay as before.
>
> If you spot misconversions in here (or other "fast forward" that need to be
> converted but I missed), please holler.
It's fine by me :)
--
Felipe Contreras
next prev parent reply other threads:[~2009-10-25 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 8:31 [PATCH] Use fast-forward Felipe Contreras
2009-10-24 8:31 ` [PATCH] Use 'fast-forward' all over the place Felipe Contreras
2009-10-24 17:50 ` Junio C Hamano
2009-10-24 19:12 ` Felipe Contreras
2009-10-24 19:44 ` Junio C Hamano
2009-10-25 8:56 ` Felipe Contreras
2009-10-25 3:41 ` Junio C Hamano
2009-10-25 7:15 ` Junio C Hamano
2009-10-25 7:19 ` Junio C Hamano
2009-10-25 7:22 ` Junio C Hamano
2009-10-25 9:06 ` Felipe Contreras [this message]
2009-10-25 9:02 ` Felipe Contreras
2009-10-24 13:07 ` [PATCH] Use fast-forward Nanako Shiraishi
2009-10-24 14:17 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530910250206v4827941cs12b88ec75975224e@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).