From: Felipe Contreras <felipe.contreras@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] send-email: new 'add-envelope' option
Date: Sat, 21 Nov 2009 21:59:33 +0200 [thread overview]
Message-ID: <94a0d4530911211159l1fadad0ldb0d760439ceb57@mail.gmail.com> (raw)
In-Reply-To: <20091121193600.GA3296@coredump.intra.peff.net>
On Sat, Nov 21, 2009 at 9:36 PM, Jeff King <peff@peff.net> wrote:
> So my first thought was "how in the world is this different from setting
> the envelope sender?"
>
> Reading the code, it seems:
[...]
> that this is a boolean to mean "use the from address as the envelope
> sender".
>
> It was of course all the more confusing for not being documented at all,
> but even if documented,
Right, I forgot the one-liner for the help.
> --envelope-from is IMHO confusingly similar to
> --envelope-sender. Maybe --use-from-in-envelope would be a better name?
Ok. I don't have any opinion on the name.
> And of course, your patch is missing docs and tests.
There are no tests for 'envelope-sender', so I don't think it should
be a requirement for this patch to do so. I'll add the documentation
though.
Will resend v2.
--
Felipe Contreras
next prev parent reply other threads:[~2009-11-21 20:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-21 17:43 [PATCH] send-email: new 'add-envelope' option Felipe Contreras
2009-11-21 19:36 ` Jeff King
2009-11-21 19:59 ` Felipe Contreras [this message]
2009-11-22 2:58 ` Junio C Hamano
2009-11-22 12:03 ` Felipe Contreras
2009-11-22 16:42 ` Junio C Hamano
2009-11-22 17:54 ` Junio C Hamano
2009-11-23 20:13 ` Felipe Contreras
2009-11-22 12:37 ` Felipe Contreras
2009-11-22 23:54 ` Junio C Hamano
2009-11-24 17:28 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530911211159l1fadad0ldb0d760439ceb57@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).