git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH] send-email: new 'add-envelope' option
Date: Mon, 23 Nov 2009 22:13:10 +0200	[thread overview]
Message-ID: <94a0d4530911231213k6ec3d4f4hb7bc293b8ddf92e8@mail.gmail.com> (raw)
In-Reply-To: <7v6392h2d9.fsf@alter.siamese.dyndns.org>

On Sun, Nov 22, 2009 at 7:54 PM, Junio C Hamano <gitster@pobox.com> wrote:
> You can say that if you want to be difficult to work with, or you can be
> that somebody yourself and make a difference.

Being difficult to work with goes both ways. You as a maintainer are
entitled to say "I won't accept this without test cases", and I as a
contributor am entitled to say "I'm not going to do that". Since I'm
doing this on my free time I'd rather work on the things I like, which
doesn't include writing test cases from scratch, primarily because I'm
not familiar with them.

> Let me show you that we can be constructive for a change ;-)
>
> How about something trivial like this?

Looks good to me, but again, that doesn't say much.

Cheers.

-- 
Felipe Contreras

  reply	other threads:[~2009-11-23 20:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-21 17:43 [PATCH] send-email: new 'add-envelope' option Felipe Contreras
2009-11-21 19:36 ` Jeff King
2009-11-21 19:59   ` Felipe Contreras
2009-11-22  2:58     ` Junio C Hamano
2009-11-22 12:03       ` Felipe Contreras
2009-11-22 16:42         ` Junio C Hamano
2009-11-22 17:54         ` Junio C Hamano
2009-11-23 20:13           ` Felipe Contreras [this message]
2009-11-22 12:37     ` Felipe Contreras
2009-11-22 23:54       ` Junio C Hamano
2009-11-24 17:28         ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94a0d4530911231213k6ec3d4f4hb7bc293b8ddf92e8@mail.gmail.com \
    --to=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).