From: Felipe Contreras <felipe.contreras@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] format-patch: fix dashdash usage
Date: Sat, 28 Nov 2009 13:18:25 +0200 [thread overview]
Message-ID: <94a0d4530911280318nd6ea6d4s7ee159fe173a3f2f@mail.gmail.com> (raw)
In-Reply-To: <7vhbsg25sb.fsf@alter.siamese.dyndns.org>
On Fri, Nov 27, 2009 at 2:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
> (0) take your patch with an updated message (eh, that is not "next step"
> but the "first step");
I guess it depends of what is the "fist step". To me the "first step"
is realizing there's a problem. First patch submission is already many
steps afterwards.
But sure, I'll do this next step :)
> (1) make --full-diff implicit and default of format-patch (--no-full-diff
> could be supported _if_ somebody can argue successfully why limiting
> the diff is also a useful thing to do); and
I started writing this patch but it turns out there's no --no-full-diff.
> (2) document clearly that format-patch takes optional pathspecs, and in
> what situation they are useful.
I guess this would have to be done in multiple places so it might take
me some time.
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2009-11-28 11:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 19:11 [PATCH 0/2] format-patch: fix dashdash Felipe Contreras
2009-11-26 19:11 ` [PATCH 1/2] format-patch: fix dashdash usage Felipe Contreras
2009-11-26 19:57 ` Junio C Hamano
2009-11-26 22:14 ` Felipe Contreras
2009-11-26 23:11 ` Junio C Hamano
2009-11-26 23:23 ` Felipe Contreras
2009-11-27 0:03 ` Junio C Hamano
2009-11-28 11:18 ` Felipe Contreras [this message]
2009-11-26 23:29 ` Junio C Hamano
2009-11-26 23:37 ` Björn Steinbrink
2009-11-26 19:12 ` [PATCH 2/2] format-patch: add test for dashdash Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94a0d4530911280318nd6ea6d4s7ee159fe173a3f2f@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).