From: Tian Yuchen <cat@malon.dev>
To: Karthik Nayak <karthik.188@gmail.com>,
Zakariyah Ali <zakariyahali100@gmail.com>,
git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4 1/1] t2000: modernize overall structure and path checks
Date: Tue, 7 Apr 2026 01:36:02 +0800 [thread overview]
Message-ID: <9639df15-8498-4dd0-8ea1-6ebaf4533476@malon.dev> (raw)
In-Reply-To: <CAOLa=ZTuk-33xz4RQJDv-nyK-MqFzLWHM7zdmBBGnXjYiJBsSQ@mail.gmail.com>
On 4/6/26 06:04, Karthik Nayak wrote:
>
> Shouldn't all the tests above (since 'mkdir path2') be a single test
> block? First we setup the data, validate the data, the previous test
> runs 'git-checkout-index' and finally here we're verifying the endstate
> here. I think this should all fit into one test block.
That makes sense. I didn’t mention this earlier because I hadn’t noticed
that the patch title had changed from 't2000: modernise path checks with
test_path_is_* helpers' to 't2000: modernise overall structure'. If this
is a overall refactor, then it would be worth revising this outdated
test structure as well ;)
>
> Thanks,
> Karthik
>
>> test_done
>> --
>> 2.43.0
Regards, Yuchen
next prev parent reply other threads:[~2026-04-06 17:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 0:15 Github Patch Zakariyah Ali
2026-03-26 0:54 ` Pablo
2026-03-26 19:26 ` [GSoC PATCH v2] t2000: modernize path checks with test_path_is_* helpers Zakariyah Ali
2026-03-26 20:29 ` Junio C Hamano
2026-03-27 23:40 ` [GSoC][PATCH v3] t2000: modernise overall structure Zakariyah Ali
2026-03-30 12:31 ` Zakariyah Ali
2026-04-01 17:09 ` Tian Yuchen
2026-04-05 1:11 ` [PATCH v4 1/1] t2000: modernize overall structure and path checks Zakariyah Ali
2026-04-05 22:04 ` Karthik Nayak
2026-04-06 17:36 ` Tian Yuchen [this message]
2026-04-07 3:44 ` [PATCH v5] " Zakariyah Ali
2026-04-07 14:29 ` Junio C Hamano
2026-04-07 16:10 ` Junio C Hamano
2026-04-29 10:36 ` [PATCH v6] t2000: consolidate second scenario into a single test block Zakariyah Ali
2026-05-05 6:42 ` Zakariyah Ali
2026-05-12 6:15 ` Junio C Hamano
2026-05-12 20:01 ` [PATCH v6] t2000: consolidate second scenario into a single test Zakariyah Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9639df15-8498-4dd0-8ea1-6ebaf4533476@malon.dev \
--to=cat@malon.dev \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karthik.188@gmail.com \
--cc=zakariyahali100@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox