From: Derrick Stolee <stolee@gmail.com>
To: "René Scharfe" <l.s.r@web.de>,
"Ramsay Jones" <ramsay@ramsayjones.plus.com>
Cc: Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] commit-graph: fix some "plain integer as NULL pointer" warnings
Date: Mon, 26 Feb 2018 09:31:35 -0500 [thread overview]
Message-ID: <968481f1-dbda-502b-0c6f-41b0232fe870@gmail.com> (raw)
In-Reply-To: <93d2329a-1963-dca8-2f9e-ba225ead9d0b@web.de>
On 2/24/2018 12:42 AM, René Scharfe wrote:
> Am 24.02.2018 um 03:24 schrieb Ramsay Jones:
>> diff --git a/commit-graph.c b/commit-graph.c
>> index fc5ee7e99..c2f443436 100644
>> --- a/commit-graph.c
>> +++ b/commit-graph.c
>> @@ -45,7 +45,7 @@ char *get_graph_latest_filename(const char *obj_dir)
>> {
>> struct strbuf fname = STRBUF_INIT;
>> strbuf_addf(&fname, "%s/info/graph-latest", obj_dir);
>> - return strbuf_detach(&fname, 0);
>> + return strbuf_detach(&fname, NULL);
>> }
> You could also replace that function body with:
>
> return xstrfmt("%s/info/graph-latest", obj_dir);
>
> René
Thanks for the feedback! I will apply these locally as I am re-rolling
today.
-Stolee
prev parent reply other threads:[~2018-02-26 14:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 2:24 [PATCH] commit-graph: fix some "plain integer as NULL pointer" warnings Ramsay Jones
2018-02-24 5:42 ` René Scharfe
2018-02-26 14:31 ` Derrick Stolee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=968481f1-dbda-502b-0c6f-41b0232fe870@gmail.com \
--to=stolee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).