From: "Rubén Justo" <rjusto@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>,
"Rubén Justo via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] branch: allow "-" as a short-hand for "previous branch"
Date: Sat, 13 Aug 2022 11:14:09 +0200 [thread overview]
Message-ID: <9693b83f-551e-e579-b267-af1d633dc381@gmail.com> (raw)
In-Reply-To: <xmqq4jymvllq.fsf@gitster.g>
On Mon, Aug 8, 2022 at 4:47 PM Junio C Hamano<gitster@pobox.com> wrote:
> The "-d" and "-D" options being the more detructive ones among other
> operation modes of the command, I am not sure if this change is even
> desirable. Even if it were, the implementation to special case a
> single argument case like this ...
>
>> + if ((argc == 1) && !strcmp(argv[0], "-")) {
>> + argv[0] = "@{-1}";
>> + }
> ... (by the way, we don't write braces around a single statement
> block) would invite cries from confused users why none of these ...
>
> $ git branch -m - new-name
> $ git branch new-branch -
> $ git branch --set-upstream-to=<upstream> -
>
> work and "-" works only for deletion.
Agree. But the approach is to ease the deletion of previous branch,
aligned with merge:
$ git merge - -
merge: - - not something we can merge
$ git merge - old-branch
merge: - - not something we can merge
In fact, I think it is a bit confuse to allow use it that way, and
probably induces to error.
Haven't think about -m, -c. If you think it is a good addition, I can do it.
I can fix the braces around that single statement block, sorry.
next prev parent reply other threads:[~2022-08-13 9:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 22:22 [PATCH] branch: allow "-" as a short-hand for "previous branch" Rubén Justo via GitGitGadget
2022-08-08 13:26 ` Johannes Schindelin
2022-08-08 16:06 ` Junio C Hamano
2022-08-13 9:19 ` Rubén Justo
2022-08-13 22:28 ` Junio C Hamano
2022-08-16 9:49 ` Johannes Schindelin
2022-08-19 13:05 ` Johannes Schindelin
2022-08-19 18:11 ` Junio C Hamano
2022-08-25 7:57 ` Rubén Justo
2022-08-25 16:23 ` Junio C Hamano
2022-08-25 19:50 ` Rubén Justo
2022-08-13 9:08 ` Rubén Justo
2022-08-08 14:46 ` Junio C Hamano
2022-08-13 9:14 ` Rubén Justo [this message]
2022-08-16 9:31 ` Johannes Schindelin
2022-08-16 17:03 ` Rubén Justo
2022-08-19 11:42 ` Johannes Schindelin
2022-08-16 17:11 ` [PATCH v2] allow "-" as short-hand for "@{-1}" in "branch -d" Rubén Justo via GitGitGadget
2022-08-16 18:55 ` Junio C Hamano
2022-08-16 21:27 ` Rubén Justo
2022-08-16 21:18 ` [PATCH v3] branch: allow "-" as a short-hand for "previous branch" Rubén Justo
2022-09-11 14:14 ` [PATCH v4] branch: allow "-" as a shortcut " Rubén Justo
2022-09-12 17:52 ` Junio C Hamano
2022-09-12 21:18 ` Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9693b83f-551e-e579-b267-af1d633dc381@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).