From: Phillip Wood <phillip.wood123@gmail.com>
To: Li Chen <me@linux.beauty>, phillipwood <phillip.wood@dunelm.org.uk>
Cc: git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [RFC PATCH 2/2] rebase: support --trailer
Date: Thu, 8 May 2025 17:29:01 +0100 [thread overview]
Message-ID: <98415c84-a5ab-4bf0-b361-dd60ff3e7dd2@gmail.com> (raw)
In-Reply-To: <196b09c1324.fba686d21234508.1995945025408421751@linux.beauty>
Hi Li
On 08/05/2025 16:55, Li Chen wrote:
> ---- On Thu, 08 May 2025 22:17:17 +0800 Phillip Wood <phillip.wood123@gmail.com> wrote ---
>
> > I've left some comments on the changes to builtin/rebase.c and the
> > tests, I've skipped the changes to sequencer.c for now as they'll have
> > to be updated to avoid forking "git interpret-trailers"
>
> Thanks for all your great reviews!
>
> I'll address all your reviews in next version.
I forgot to say earlier that if you have any questions or queries about
my review or the trailer code do feel free to ask.
Best Wishes
Phillip
next prev parent reply other threads:[~2025-05-08 16:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 12:57 [RFC PATCH 0/2] rebase: support --trailer and add --reviewby Li Chen
2025-05-06 12:58 ` [RFC PATCH 1/2] rebase, am: add --reviewby option Li Chen
2025-05-06 18:07 ` Junio C Hamano
2025-05-07 6:46 ` Li Chen
2025-05-07 10:17 ` Phillip Wood
2025-05-07 10:26 ` Phillip Wood
2025-05-07 10:39 ` Kristoffer Haugsbakk
2025-05-07 13:38 ` Phillip Wood
2025-05-07 17:39 ` Junio C Hamano
2025-05-06 12:58 ` [RFC PATCH 2/2] rebase: support --trailer Li Chen
2025-05-08 14:17 ` Phillip Wood
2025-05-08 15:55 ` Li Chen
2025-05-08 15:58 ` phillip.wood123
2025-05-08 16:29 ` Phillip Wood [this message]
2025-05-16 5:42 ` Li Chen
2025-05-16 10:04 ` Phillip Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98415c84-a5ab-4bf0-b361-dd60ff3e7dd2@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@linux.beauty \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).