From: "Blake Ramsdell" <blaker@gmail.com>
To: "Wincent Colaiuta" <win@wincent.com>
Cc: git@vger.kernel.org, jnareb@gmail.com
Subject: Re: [PATCH] Silence iconv warnings on Leopard
Date: Thu, 6 Dec 2007 15:04:08 -0800 [thread overview]
Message-ID: <985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com> (raw)
In-Reply-To: <1196968023-45284-1-git-send-email-win@wincent.com>
On Dec 6, 2007 11:07 AM, Wincent Colaiuta <win@wincent.com> wrote:
> Apple ships a newer version of iconv with Leopard (Mac OS X 10.5/Darwin
> 9). Ensure that OLD_ICONV is not set on any version of Darwin in the
> 9.x series; this should be good for at least a couple of years, when
> Darwin 10 comes out and we can invert the sense of the test to
> specifically check for Darwin 7 or 8.
This approach seems fine to me, there was some concern about matching
the OS type / version in the past, but I haven't really seen a better
answer.
> A more sophisticated and robust check is possible for those who use
> autoconf, but not everybody does that.
I did make a patch for configure.ac that does this. If it's
interesting, I'll send it along.
Blake
--
Blake Ramsdell | http://www.blakeramsdell.com
next prev parent reply other threads:[~2007-12-06 23:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:07 [PATCH] Silence iconv warnings on Leopard Wincent Colaiuta
2007-12-06 23:04 ` Blake Ramsdell [this message]
2007-12-07 0:11 ` Jakub Narebski
2007-12-07 0:12 ` Blake Ramsdell
2007-12-07 0:30 ` Linus Torvalds
2007-12-07 0:41 ` Blake Ramsdell
2007-12-07 0:44 ` Blake Ramsdell
2007-12-07 1:27 ` [PATCH/RFC (take 3)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-07 7:26 ` Junio C Hamano
2007-12-07 8:25 ` Wincent Colaiuta
2007-12-07 8:22 ` Wincent Colaiuta
2007-12-07 8:29 ` Blake Ramsdell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985966520712061504s686395d6jf680363c7b3b9de7@mail.gmail.com \
--to=blaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).