From: "Blake Ramsdell" <blaker@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Jakub Narebski" <jnareb@gmail.com>,
"Wincent Colaiuta" <win@wincent.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Silence iconv warnings on Leopard
Date: Thu, 6 Dec 2007 16:44:04 -0800 [thread overview]
Message-ID: <985966520712061644k72a4c4ecpfe26d4e00d14b337@mail.gmail.com> (raw)
In-Reply-To: <985966520712061641y4eba054dj5dea1d0308d50b12@mail.gmail.com>
On Dec 6, 2007 4:41 PM, Blake Ramsdell <blaker@gmail.com> wrote:
> On Dec 6, 2007 4:30 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
> > Umm. Why not just make the test be whether the following compiles cleanly?
> >
> > #include <iconv.h>
> >
> > extern size_t iconv(iconv_t cd,
> > char **inbuf, size_t *inbytesleft,
> > char **outbuf, size_t *outbytesleft);
> >
> > because if the compiler has seen a "const char **inbuf", then it should
> > error out with a "conflicting types for 'iconv'" style message..
>
> Yeah, this is what I did:
My apologies. Your suggestion is completely different, and should work
without -Werror. Let me try that.
Blake
--
Blake Ramsdell | http://www.blakeramsdell.com
next prev parent reply other threads:[~2007-12-07 0:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:07 [PATCH] Silence iconv warnings on Leopard Wincent Colaiuta
2007-12-06 23:04 ` Blake Ramsdell
2007-12-07 0:11 ` Jakub Narebski
2007-12-07 0:12 ` Blake Ramsdell
2007-12-07 0:30 ` Linus Torvalds
2007-12-07 0:41 ` Blake Ramsdell
2007-12-07 0:44 ` Blake Ramsdell [this message]
2007-12-07 1:27 ` [PATCH/RFC (take 3)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-07 7:26 ` Junio C Hamano
2007-12-07 8:25 ` Wincent Colaiuta
2007-12-07 8:22 ` Wincent Colaiuta
2007-12-07 8:29 ` Blake Ramsdell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985966520712061644k72a4c4ecpfe26d4e00d14b337@mail.gmail.com \
--to=blaker@gmail.com \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).