From: "Blake Ramsdell" <blaker@gmail.com>
To: "Jakub Narebski" <jnareb@gmail.com>
Cc: git@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Wincent Colaiuta" <win@wincent.com>,
"Junio C Hamano" <gitster@pobox.com>,
"Pascal Obry" <pascal@obry.net>,
"Ramsay Jones" <ramsay@ramsay1.demon.co.uk>,
"Arjen Laarhoven" <arjen@yaph.org>,
"Brian Gernhardt" <benji@silverinsanity.com>
Subject: Re: [PATCH/RFC (take 3)] autoconf: Add test for OLD_ICONV (squelching compiler warning)
Date: Fri, 7 Dec 2007 00:29:42 -0800 [thread overview]
Message-ID: <985966520712070029y2a3402caia81524f8dc0c608e@mail.gmail.com> (raw)
In-Reply-To: <1196990840-1168-1-git-send-email-jnareb@gmail.com>
On Dec 6, 2007 5:27 PM, Jakub Narebski <jnareb@gmail.com> wrote:
> Is something like the patch below what you wanted to try?
Yes. Not sure if main() is required, so it might be shorter if that's
removed, but not really relevant as long as it works.
And CHECKS for header files might be considered chatty.
Blake
--
Blake Ramsdell | http://www.blakeramsdell.com
prev parent reply other threads:[~2007-12-07 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 19:07 [PATCH] Silence iconv warnings on Leopard Wincent Colaiuta
2007-12-06 23:04 ` Blake Ramsdell
2007-12-07 0:11 ` Jakub Narebski
2007-12-07 0:12 ` Blake Ramsdell
2007-12-07 0:30 ` Linus Torvalds
2007-12-07 0:41 ` Blake Ramsdell
2007-12-07 0:44 ` Blake Ramsdell
2007-12-07 1:27 ` [PATCH/RFC (take 3)] autoconf: Add test for OLD_ICONV (squelching compiler warning) Jakub Narebski
2007-12-07 7:26 ` Junio C Hamano
2007-12-07 8:25 ` Wincent Colaiuta
2007-12-07 8:22 ` Wincent Colaiuta
2007-12-07 8:29 ` Blake Ramsdell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985966520712070029y2a3402caia81524f8dc0c608e@mail.gmail.com \
--to=blaker@gmail.com \
--cc=arjen@yaph.org \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=pascal@obry.net \
--cc=ramsay@ramsay1.demon.co.uk \
--cc=torvalds@linux-foundation.org \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).