Re: [PATCH] t1016: clean up style

["Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>]

Hi

On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:
> Use `test_config`.
>
> Remove whitespace after redirect operator.
>
> Reported-by: Taylor Blau <me@ttaylorr.com>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> As discussed in:
>   - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/
> […]
> -		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> -		echo "Hellow World!" > hello &&
> +		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> +		echo "Hellow World!" >hello &&

What Taylor wrote:

> Thanks, both. [Andrew] -- it's fine to do this in the same, or a
> separate patch in the new round. Thanks.

You’ve posted a new, standalone patch.  But what Taylor asked for was a
new round on that typo patch where you either squash these changes into
the original patch or have the typo patch plus this one.

At least that’s how I understand it.

This patch by itself doesn’t do much since the file is full of this
style violation.  Which I now realize is what you meant when you
asked:[1]

> Do you mean that '> more' and '> another' should be handled similarly?

You were referring to other style violations in the file.  But I only
looked at the email so I didn’t catch that.

🔗 1: https://lore.kernel.org/git/ZxKSFBl_pV2r99dY@void.void/