From: Chris Webb <chris@arachsys.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line
Date: Thu, 15 Apr 2010 15:41:59 +0100 [thread overview]
Message-ID: <9946ffbdf26e7b08b9b00b87d4b575fea774be4c.1271342450.git.chris@arachsys.com> (raw)
Put the current date in the 'From COMMIT DATE' header line instead of using
the fixed date 'Mon Sep 17 00:00:00 2001'. A DATE_UTC mode for show_date() is
introduced so we can easily generate this line in the correct format.
Signed-off-by: Chris Webb <chris@arachsys.com>
---
builtin/blame.c | 1 +
cache.h | 3 ++-
date.c | 4 +++-
log-tree.c | 2 +-
4 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/builtin/blame.c b/builtin/blame.c
index fc15863..42fb1bd 100644
--- a/builtin/blame.c
+++ b/builtin/blame.c
@@ -2301,6 +2301,7 @@ parse_done:
/* "normal" is used as the fallback for "relative" */
case DATE_LOCAL:
case DATE_NORMAL:
+ case DATE_UTC:
blame_date_width = sizeof("Thu Oct 19 16:00:04 2006 -0700");
break;
}
diff --git a/cache.h b/cache.h
index 5eb0573..fdb0643 100644
--- a/cache.h
+++ b/cache.h
@@ -769,7 +769,8 @@ enum date_mode {
DATE_LOCAL,
DATE_ISO8601,
DATE_RFC2822,
- DATE_RAW
+ DATE_RAW,
+ DATE_UTC
};
const char *show_date(unsigned long time, int timezone, enum date_mode mode);
diff --git a/date.c b/date.c
index 002aa3c..88b1b58 100644
--- a/date.c
+++ b/date.c
@@ -166,6 +166,8 @@ const char *show_date(unsigned long time, int tz, enum date_mode mode)
if (mode == DATE_LOCAL)
tz = local_tzoffset(time);
+ else if (mode == DATE_UTC)
+ tz = 0;
tm = time_to_tm(time, tz);
if (!tm)
@@ -192,7 +194,7 @@ const char *show_date(unsigned long time, int tz, enum date_mode mode)
tm->tm_mday,
tm->tm_hour, tm->tm_min, tm->tm_sec,
tm->tm_year + 1900,
- (mode == DATE_LOCAL) ? 0 : ' ',
+ (mode != DATE_NORMAL) ? 0 : ' ',
tz);
return timebuf;
}
diff --git a/log-tree.c b/log-tree.c
index d3ae969..798baf6 100644
--- a/log-tree.c
+++ b/log-tree.c
@@ -217,7 +217,7 @@ void log_write_email_headers(struct rev_info *opt, struct commit *commit,
subject = "Subject: ";
}
- printf("From %s Mon Sep 17 00:00:00 2001\n", name);
+ printf("From %s %s\n", name, show_date(time(NULL), 0, DATE_UTC));
graph_show_oneline(opt->graph);
if (opt->message_id) {
printf("Message-Id: <%s>\n", opt->message_id);
--
1.7.0.3
next reply other threads:[~2010-04-15 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 14:41 Chris Webb [this message]
2010-04-15 15:16 ` [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Chris Webb
2010-04-15 15:35 ` Thomas Rast
2010-04-15 15:55 ` Chris Webb
2010-04-17 18:16 ` Junio C Hamano
2010-04-15 15:57 ` [PATCH] Fix t4013 with current date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-15 23:19 ` [PATCH] format-patch: use current date in mbox 'From COMMIT DATE' header line Jonathan Nieder
2010-04-16 7:52 ` Chris Webb
2010-04-16 16:42 ` [PATCH v2 1/2] format-patch: use commit " Chris Webb
2010-04-16 16:42 ` [PATCH 2/2] Fix t4013 with commit date in mbox 'From COMMIT DATE' header lines Chris Webb
2010-04-16 17:59 ` Santi Béjar
2010-04-17 8:01 ` [PATCH v3] format-patch: use commit date in mbox 'From COMMIT DATE' header line Chris Webb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9946ffbdf26e7b08b9b00b87d4b575fea774be4c.1271342450.git.chris@arachsys.com \
--to=chris@arachsys.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).