Re: [PATCH v4 1/2] stash: reserve exit status 1 for conflicts

[Phillip Wood <phillip.wood123@gmail.com>]

[Cc'd Karthik for a view on the CI style job]

On 04/09/2026 09:16, Harald Nordgren wrote:
>> A local "make style" while you develop runs
>>
>>          git clang-format --style file --diff --extensions c,h
>>
>> which tells the command to check only the parts of the system that
>> you touched.
>>
>> I do not think it is used in CI.
> 
> It seems to run as part of CI and doesn't catch it then:
> '.github/workflows/check-style.yml'

My recollection is that we made that job never fail because clang-format 
does not always do a good job of following our style guide and the 
output is not guaranteed to be stable across different versions. That 
makes its value debatable as I don't think many people (anyone?) bother 
checking the output to see what suggestions it made. It would be a lot 
simpler for contributors if we just devolved style decisions to 
clang-format so no one had to think about or comment on the style. 
Whether that tradeoff is worth it depends on how far the output of 
clang-format deviates from our preferred style.

Thanks

Phillip