From: "Kyle J. McKay" <mackyle@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Jonathon Mah <me@jonathonmah.com>,
Junio C Hamano <gitster@pobox.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: [PATCH 2/2] sha1_file: fix iterating loose alternate objects
Date: Mon, 9 Feb 2015 01:44:51 -0800 [thread overview]
Message-ID: <9DC6FCD7-8C5B-464F-B47F-EC8AC37E9549@gmail.com> (raw)
In-Reply-To: <20150209011538.GB21123@peff.net>
On Feb 8, 2015, at 17:15, Jeff King wrote:
[...]
> Signed-off-by: Jonathon Mah <me@JonathonMah.com>
> Helped-by: Kyle J. McKay <mackyle@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> I think the S-O-B should still stand, as the code is now a mix of our
> work, and the tests are still Jonathon's. But let me know if you do
> not
> want your name attached to this. ;)
That's fine.
This fix looks much better. :)
Unfortunately I can no longer reproduce the original bug as the
repository that caused it is no longer in a state that triggers the
problem (and my backups of it are either slightly too old or slightly
too new).
-Kyle
next prev parent reply other threads:[~2015-02-09 9:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 23:05 [PATCH] sha1_file.c: make sure open_sha1_file does not open a directory Kyle J. McKay
2015-02-09 0:54 ` Jeff King
2015-02-09 1:12 ` Jeff King
2015-02-09 1:13 ` [PATCH 1/2] for_each_loose_file_in_objdir: take an optional strbuf path Jeff King
2015-02-09 1:15 ` [PATCH 2/2] sha1_file: fix iterating loose alternate objects Jeff King
2015-02-09 9:44 ` Kyle J. McKay [this message]
2015-02-09 18:48 ` [PATCH] sha1_file.c: make sure open_sha1_file does not open a directory Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2015-02-01 21:55 [PATCH 1/2] t5710-info-alternate: demonstrate bug in unpacked pruning Jonathon Mah
2015-02-01 21:55 ` [PATCH 2/2] sha1_file: fix iterating loose alternate objects Jonathon Mah
2015-02-02 17:53 ` Jeff King
2015-02-02 18:37 ` Jonathon Mah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9DC6FCD7-8C5B-464F-B47F-EC8AC37E9549@gmail.com \
--to=mackyle@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@jonathonmah.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).