From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D6E8C761A6 for ; Sat, 1 Apr 2023 02:54:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbjDACyO (ORCPT ); Fri, 31 Mar 2023 22:54:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231775AbjDACyN (ORCPT ); Fri, 31 Mar 2023 22:54:13 -0400 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFAA212CD5 for ; Fri, 31 Mar 2023 19:54:12 -0700 (PDT) Received: by mail-pl1-x62c.google.com with SMTP id iw3so23151816plb.6 for ; Fri, 31 Mar 2023 19:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680317652; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uMSE3/v/bsXXJZkpw0o7G9alPCc7KTWV8evMDO1g3fY=; b=Lhben/Gxzxh949irbKYGP8h0k4ATFkhFFgmya6hyso10KJ6x7Yn12I6fybxGseDo9d rSDOhpzMM7Z3m/72syai5whqA2eehW5rmRLln5wtAdZ/I5OphkuFNH/Gz8TdkvN3ghIt 8MV1MIx8QuL3QOeVH3FVIdiJhc4bLrBHd9+v6JMqsThmYyinjUMlIy0+4vK0CT7ylNop 4/5e0G247AR6zWJnPddJ6DqXY7ylErcuhZ2SIz2OmlQ1QaOFWDma5yccYUIUnar5wOp0 na6g+Zz/wRlx72j1gGlqbbY2bJUx5oBFCCB4sIqc02wE0fe4e4CrDn3nWEw2FGW+xoMR /tfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680317652; h=content-transfer-encoding:in-reply-to:cc:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uMSE3/v/bsXXJZkpw0o7G9alPCc7KTWV8evMDO1g3fY=; b=5SX/sy8zZdZZq4wOPNgFrZ2kuDTlaaOmxgT9xhJfDCaJBvU7dcIKdW/+6eAmVR4PPK PMrpx2mhoZBwI/Hhys3TXtu+nGEdxJjOjmK5/2bkUdDrRs7wZHHKgvMEEI7fhA4e9k/H Nbp8rQGbxUyROnCr9mtvz83b6N9qDjO62wBYIiPsxejZ/EDyr7z+K/vzdmKXdloER5uM I+siaGJntQ3SxZdFqnGm8xAnS9bfhXCmNz0lFCQsvBqeCSa3Gx1FnkaHlk0t1BtRYUfr z4V5yKYxojC9euq8KEpo4ofQFB0HFBnMW0d/QcBSOAiJhnF3wddIyc6ItVLDtWsQ6i8H yXdw== X-Gm-Message-State: AAQBX9cfqekW3fKID1LgJTVPQ94OnN7u1kmath0mcDo+AQbUbjFc/GS0 ubWFLBk//gM4xXdp9GLOQlWcWJEdXJQ5rw== X-Google-Smtp-Source: AKy350bPNJ/XQd9sgVspftfrrFShemi+XRM9/sfMm4My3W+TWDuouA6R9s2WwAr/3d+9fP031/WCyQ== X-Received: by 2002:a17:902:d4ce:b0:19e:b2ed:6fff with SMTP id o14-20020a170902d4ce00b0019eb2ed6fffmr13541447plg.31.1680317652154; Fri, 31 Mar 2023 19:54:12 -0700 (PDT) Received: from [192.168.43.80] (subs02-180-214-232-71.three.co.id. [180.214.232.71]) by smtp.gmail.com with ESMTPSA id jg2-20020a17090326c200b0019a8530c063sm2252159plb.102.2023.03.31.19.54.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 19:54:11 -0700 (PDT) Message-ID: <9a0948e2-d030-ac89-a009-9247054f71f9@gmail.com> Date: Sat, 1 Apr 2023 09:54:08 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] hooks: add sendemail-validate-series Content-Language: en-US To: Robin Jarry , git@vger.kernel.org References: <20230103231133.64050-1-robin@jarry.cc> From: Bagas Sanjaya Cc: Junio C Hamano In-Reply-To: <20230103231133.64050-1-robin@jarry.cc> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 1/4/23 06:11, Robin Jarry wrote: > +sendemail-validate-series > +~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +This hook is invoked by linkgit:git-send-email[1]. It allows performing > +validation on a complete patch series at once, instead of patch by patch with > +`sendemail-validate`. > + > +`sendemail-validate-series` takes no arguments, but for each e-mail to be sent > +it receives on standard input a line of the format: > + > + LF > + > +where `` is a name of a file that holds an e-mail to be sent, > + In most cases, the patch series is generated by git-format-patch(1). When the command is run, it will output: ``` $ git format-patch -o /tmp --cover-letter --base= /tmp/0000-cover-letter.patch /tmp/0001-.patch /tmp/0002-.patch /tmp/0003-.patch ... ``` The output can be fed to the hook (as you write). But I think the hook should also take patch file arguments, for the sake of completeness with sendemail-validate hook; that is: ``` sendemail-validate-series ... ``` Also, there should have a check that In-Reply-To must be the first patch in the given series or the cover letter (if there is one). Anyway, rather than pinging by random people, I'd like to see [PATCH RESEND], rebased on latest git.git tree, ideally with Junio Cc'ed. Thanks. -- An old man doll... just what I always wanted! - Clara