From: Jeff Hostetler <git@jeffhostetler.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Jeff Hostetler <jeffhost@microsoft.com>
Subject: Re: [PATCH v8 2/2] json-writer: t0019: add perl unit test
Date: Mon, 11 Jun 2018 08:16:44 -0400 [thread overview]
Message-ID: <9aeac3a6-ea04-a43e-3851-1083792dfb5d@jeffhostetler.com> (raw)
In-Reply-To: <CAPig+cS8MjQNKabrQwuWzO4DDYJcfP_81n9H37efgXOiRzv9TQ@mail.gmail.com>
On 6/7/2018 1:13 PM, Eric Sunshine wrote:
> On Thu, Jun 7, 2018 at 10:12 AM, <git@jeffhostetler.com> wrote:
>> Test json-writer output using perl script.
>>
>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>> ---
>> diff --git a/t/t0019/parse_json.perl b/t/t0019/parse_json.perl
>> @@ -0,0 +1,52 @@
>> +#!/usr/bin/perl
>> +use strict;
>> +use warnings;
>> +use JSON;
>
> This new script is going to have to be protected by a prerequisite
> since the JSON module is not part of the standard Perl installation,
> thus will not necessarily be installed everywhere (it isn't on any of
> my machines, for instance). Something like:
>
> test_lazy_prereq PERLJSON '
> perl -MJSON -e "exit 0"
> '
>
> which would be used like this:
>
> test_expect_success PERLJSON 'parse JSON using Perl' '
> ...
> '
>
will do. thanks!
Jeff
prev parent reply other threads:[~2018-06-11 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 14:12 [PATCH v8 0/2] json-writer V8 git
2018-06-07 14:12 ` [PATCH v8 1/2] json_writer: new routines to create data in JSON format git
2018-06-07 17:24 ` Eric Sunshine
2018-06-08 20:17 ` Jeff Hostetler
2018-06-08 6:05 ` René Scharfe
2018-06-11 11:43 ` Jeff Hostetler
2018-06-08 20:07 ` René Scharfe
2018-06-11 11:51 ` Jeff Hostetler
2018-06-08 20:32 ` René Scharfe
2018-06-11 10:40 ` Jeff Hostetler
2018-06-07 14:12 ` [PATCH v8 2/2] json-writer: t0019: add perl unit test git
2018-06-07 17:13 ` Eric Sunshine
2018-06-11 12:16 ` Jeff Hostetler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aeac3a6-ea04-a43e-3851-1083792dfb5d@jeffhostetler.com \
--to=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).