From: demerphq <demerphq@gmail.com>
To: "Matt Kraai" <kraai@ftbfs.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitweb: merge boolean feature subroutines
Date: Sat, 3 Jan 2009 17:18:44 +0100 [thread overview]
Message-ID: <9b18b3110901030818i242d81ccl20ef3f264ec64cad@mail.gmail.com> (raw)
In-Reply-To: <1230996692-7182-1-git-send-email-kraai@ftbfs.org>
2009/1/3 Matt Kraai <kraai@ftbfs.org>:
[...]
> -sub feature_blame {
> - my ($val) = git_get_project_config('blame', '--bool');
> +sub feature_bool {
> + my $key = shift;
> + my ($val) = git_get_project_config($key, '--bool');
>
> if ($val eq 'true') {
> return 1;
Maybe that should be:
return ($val eq 'true');
as It is not a good idea to use 0 as a replacement for perls false, as
the two have different behaviour.
$perl -wle'my $val=shift; my $x=$val eq "true"; print "<$_>" for $x, 0+$x' false
<>
<0>
Cheers,
yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"
next prev parent reply other threads:[~2009-01-03 16:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-03 15:31 [PATCH] gitweb: merge boolean feature subroutines Matt Kraai
2009-01-03 15:31 ` [PATCH] gitweb: pass the key to the " Matt Kraai
2009-01-03 16:18 ` demerphq [this message]
2009-01-03 16:40 ` [PATCH] gitweb: merge boolean " Matt Kraai
2009-01-03 16:51 ` demerphq
2009-01-03 17:13 ` Matt Kraai
2009-01-03 17:41 ` demerphq
2009-01-04 5:30 ` Junio C Hamano
2009-01-04 11:41 ` demerphq
2009-01-04 15:58 ` Matt Kraai
2009-01-04 22:07 ` Jakub Narebski
2009-01-04 21:25 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b18b3110901030818i242d81ccl20ef3f264ec64cad@mail.gmail.com \
--to=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=kraai@ftbfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).