git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: demerphq <demerphq@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: Robert Zeh <robert.a.zeh@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add git svn gc command
Date: Mon, 20 Jul 2009 11:02:15 +0200	[thread overview]
Message-ID: <9b18b3110907200202kbb78c8dm43e0451900e4f2fb@mail.gmail.com> (raw)
In-Reply-To: <20090720083621.GA3237@dcvr.yhbt.net>

2009/7/20 Eric Wong <normalperson@yhbt.net>:
> demerphq <demerphq@gmail.com> wrote:
>> 2009/7/20 Eric Wong <normalperson@yhbt.net>:
>> > Robert Zeh <robert.a.zeh@gmail.com> wrote:
>> >> --- a/git-svn.perl
>> >> +++ b/git-svn.perl
>> >> @@ -35,11 +35,14 @@ push @Git::SVN::Ra::ISA, 'SVN::Ra';
>> >>  push @SVN::Git::Editor::ISA, 'SVN::Delta::Editor';
>> >>  push @SVN::Git::Fetcher::ISA, 'SVN::Delta::Editor';
>> >>  use Carp qw/croak/;
>> >> +use Compress::Zlib;
>> >
>> > I'd "require" Compress::Zlib lazilly so it's not loaded at startup.
>> > It's not a stock component of Perl and not needed for the majority of
>> > commands.
>>
>> Actually, it has been a core component since 5.9.3
>
> Ah thanks for pointing that out, I didn't notice my 5.10.x install had
> it.  Nevertheless, git svn needs to continue supporting 5.8.x for a
> while longer.

I guess something like:

my $can_compress= eval "require Compress::Zlib; 1";

would be the right solution.




-- 
perl -Mre=debug -e "/just|another|perl|hacker/"

  reply	other threads:[~2009-07-20  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-19 23:00 [PATCH] Add git svn gc command Robert Zeh
2009-07-20  7:59 ` Eric Wong
2009-07-20  8:15   ` demerphq
2009-07-20  8:36     ` Eric Wong
2009-07-20  9:02       ` demerphq [this message]
2009-07-20 11:41         ` Thomas Rast
2009-07-20 12:18           ` demerphq
     [not found]   ` <1030C457-44CB-4D78-A692-8F3B34A3E9BD@gmail.com>
2009-07-21  3:25     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b18b3110907200202kbb78c8dm43e0451900e4f2fb@mail.gmail.com \
    --to=demerphq@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    --cc=robert.a.zeh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).