From: demerphq <demerphq@gmail.com>
To: Thomas Rast <trast@student.ethz.ch>
Cc: Eric Wong <normalperson@yhbt.net>,
Robert Zeh <robert.a.zeh@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] Add git svn gc command
Date: Mon, 20 Jul 2009 14:18:48 +0200 [thread overview]
Message-ID: <9b18b3110907200518p57a8b3gdfb51004e274b2bc@mail.gmail.com> (raw)
In-Reply-To: <200907201342.01912.trast@student.ethz.ch>
2009/7/20 Thomas Rast <trast@student.ethz.ch>:
> demerphq wrote:
>>
>> my $can_compress= eval "require Compress::Zlib; 1";
>
> Wouldn't
>
> my $can_compress = eval { require Compress::Zlib; 1 };
>
> be better on the grounds that this will catch compilation errors in
> the eval'd statement at compilation (of the main program) time?
Yeah, thats a good catch. In this case there is no need for the eval
STRING usage.
cheers,
Yves
--
perl -Mre=debug -e "/just|another|perl|hacker/"
next prev parent reply other threads:[~2009-07-20 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-19 23:00 [PATCH] Add git svn gc command Robert Zeh
2009-07-20 7:59 ` Eric Wong
2009-07-20 8:15 ` demerphq
2009-07-20 8:36 ` Eric Wong
2009-07-20 9:02 ` demerphq
2009-07-20 11:41 ` Thomas Rast
2009-07-20 12:18 ` demerphq [this message]
[not found] ` <1030C457-44CB-4D78-A692-8F3B34A3E9BD@gmail.com>
2009-07-21 3:25 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b18b3110907200518p57a8b3gdfb51004e274b2bc@mail.gmail.com \
--to=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=robert.a.zeh@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).